feat: users row actions accept plugin entries

The per-row user actions menu was hard-wired to a fixed list and any
plugin-contributed control had to sit as a separate trigger beside
the dropdown. Move the seam: plugins now contribute dropdown items
directly via `users.rowActions`, and we dispatch the click to the
plugin entry by key while the host's `handleSelect` keeps owning
the built-in keys.

Each entry is `{ key, labelId, icon?, danger?, show?(user), onClick(user) }`.
For UI state the onClick might need (drawers, modals), plugins can
mount a single `components.UsersPageGlobal` slot that the page now
renders once outside the table — typical pattern is a jotai atom
the rowAction writes to and the global slot reads from.

Drop the side-mounted `PluginExtraFields name="UserRowActions"` and
its surrounding `<Space>`; the action column is back to a single
DropdownButtons with all entries in one menu.
This commit is contained in:
gitlawr
2026-05-11 19:30:21 +08:00
committed by jialin
parent df53774628
commit 8d17000272
2 changed files with 79 additions and 17 deletions
+73 -17
View File
@@ -1,6 +1,6 @@
// columns.ts
import PluginExtraFields from '@/components/plugin-extra-fields';
import { tableSorter } from '@/config/settings';
import { getGPUStackPlugin } from '@/plugins';
import {
AutoTooltip,
DropdownButtons,
@@ -9,11 +9,32 @@ import {
} from '@gpustack/core-ui';
import { useIntl, useModel } from '@umijs/max';
import { useMemoizedFn } from 'ahooks';
import { Space, Tag } from 'antd';
import { Tag } from 'antd';
import { ColumnsType } from 'antd/lib/table';
import dayjs from 'dayjs';
import { useMemo } from 'react';
import { ListItem } from '../config/types';
// Plugin slot: an enterprise plugin can contribute additional entries
// to the user-row action dropdown via `users.rowActions`. Each entry
// owns its own click behaviour (the host just dispatches by key);
// register a single global drawer/modal under `components.
// UsersPageGlobal` to host any UI state the click needs to open.
//
// `placement` controls where the entry lands relative to the built-in
// items. Default: `before-danger` — appended after the safe entries
// and before the destructive ones (delete). `after-edit` slots the
// entry right after `Edit`, grouping "modify the user" actions
// together before any lifecycle ops.
type PluginRowAction = {
key: string;
labelId: string;
icon?: React.ReactNode;
danger?: boolean;
placement?: 'after-edit' | 'before-danger';
show?: (user: ListItem) => boolean;
onClick: (user: ListItem) => void;
};
interface ColumnsHookProps {
handleSelect: (val: string, record: ListItem) => void;
sortOrder: string[];
@@ -49,9 +70,11 @@ const useUsersColumns = ({
}: ColumnsHookProps): ColumnsType<ListItem> => {
const intl = useIntl();
const { initialState } = useModel('@@initialState') || {};
const pluginRowActions: PluginRowAction[] =
getGPUStackPlugin()?.users?.rowActions ?? [];
const setActions = useMemoizedFn((record: ListItem) => {
return actionList.filter((action) => {
const builtIn = actionList.filter((action) => {
if (action.key === 'delete') {
return initialState?.currentUser?.id !== record.id;
}
@@ -63,6 +86,48 @@ const useUsersColumns = ({
}
return true;
});
const eligible = pluginRowActions.filter((a) =>
a.show ? a.show(record) : true
);
const toItem = (a: PluginRowAction): Global.ActionItem<ListItem> => ({
label: a.labelId,
key: a.key,
icon: a.icon,
props: a.danger ? { danger: true } : undefined
});
const afterEdit = eligible
.filter((a) => a.placement === 'after-edit')
.map(toItem);
const beforeDanger = eligible
.filter((a) => (a.placement ?? 'before-danger') === 'before-danger')
.map(toItem);
// Splice in `after-edit` entries right after the `edit` built-in
// so "modify the user" actions group together. Everything else
// goes after the safe built-ins; danger built-ins (delete) stay
// at the very bottom regardless of where plugin items landed.
const editIdx = builtIn.findIndex((a) => a.key === 'edit');
const withAfterEdit =
editIdx >= 0
? [
...builtIn.slice(0, editIdx + 1),
...afterEdit,
...builtIn.slice(editIdx + 1)
]
: [...afterEdit, ...builtIn];
const merged = [...withAfterEdit, ...beforeDanger];
const safe = merged.filter((a) => !a.props?.danger);
const danger = merged.filter((a) => a.props?.danger);
return [...safe, ...danger];
});
const onSelectAction = useMemoizedFn((val: string, record: ListItem) => {
const fromPlugin = pluginRowActions.find((a) => a.key === val);
if (fromPlugin) {
fromPlugin.onClick(record);
return;
}
handleSelect(val, record);
});
return useMemo(() => {
@@ -198,23 +263,14 @@ const useUsersColumns = ({
dataIndex: 'operation',
span: 3,
render: (text, record) => (
// Plugin slot for per-row user actions. If no plugin is
// registered, `PluginExtraFields` renders nothing and the
// cell looks exactly as before.
<Space size={4}>
<DropdownButtons
items={setActions(record)}
onSelect={(val) => handleSelect(val, record)}
/>
<PluginExtraFields
name="UserRowActions"
context={{ user: record }}
/>
</Space>
<DropdownButtons
items={setActions(record)}
onSelect={(val) => onSelectAction(val, record)}
/>
)
}
];
}, [sortOrder, intl, handleSelect, setActions]);
}, [sortOrder, intl, setActions, onSelectAction]);
};
export default useUsersColumns;
+6
View File
@@ -1,3 +1,4 @@
import PluginExtraFields from '@/components/plugin-extra-fields';
import { PageAction } from '@/config';
import { PaginationKey, TABLE_SORT_DIRECTIONS } from '@/config/settings';
import type { PageActionType } from '@/config/types';
@@ -216,6 +217,11 @@ const Users: React.FC = () => {
onOk={handleModalOk}
></AddModal>
<DeleteModal ref={modalRef}></DeleteModal>
{/* Plugin mount point for global Users-page UI (e.g. a
memberships drawer driven from a `users.rowActions`
entry's onClick). Renders nothing when no plugin is
registered. */}
<PluginExtraFields name="UsersPageGlobal" />
</>
);
};