fix: remove k8s options section and merge into advance

And re-order the configuration inputs. The current input order is:
- namespace
- volume mounts
- registry credentials
- node selector
- system-default-registry
- operator image
- gpu instance static access address
- worker config yaml
This commit is contained in:
Yuxing Deng
2026-06-03 23:17:38 +08:00
committed by jialin
parent 4810ff2dbe
commit 8f0e3a7576
9 changed files with 121 additions and 86 deletions
@@ -7,21 +7,20 @@ import styled from 'styled-components';
import ImageCredential from './image-credential';
import K8SVolumeMount from './k8s-volume-mount';
const Title = styled.div`
display: flex;
align-items: center;
justify-content: space-between;
background-color: transparent;
font-weight: 500;
font-size: 14px;
padding-top: 0px;
padding-bottom: 8px;
`;
const SectionWrap = styled.div`
margin-bottom: 16px;
`;
// SwitchCard always renders a content <div> while the switch is on (it's meant
// to wrap expandable children). We render no children here, so that div is
// empty — but the card is a flex column with an 8px gap, so the empty div still
// adds height and makes the card jump as the switch toggles. Hide it.
const SwitchCardWrap = styled.div`
& > div > div:empty {
display: none;
}
`;
const NodeSelectorForm: React.FC = () => {
const intl = useIntl();
@@ -57,7 +56,7 @@ const NamespaceForm: React.FC = () => {
);
};
const OperatorImageForm: React.FC = () => {
export const OperatorImageForm: React.FC = () => {
const intl = useIntl();
return (
@@ -76,55 +75,87 @@ const OperatorImageForm: React.FC = () => {
);
};
const GpuInstanceOptionsForm: React.FC = () => {
// The presence of `gpuInstanceOptions` on `k8s_options` is the source of truth
// for whether GPU instances are enabled. Both the switch (rendered up top) and
// the static-address field (rendered in the advanced section) watch this same
// path so they stay in sync without sharing local state.
const GPU_INSTANCE_OPTIONS_PATH = ['k8s_options', 'gpuInstanceOptions'];
// Standalone switch shown directly under the cluster description. Toggling it
// only flips the presence of `gpuInstanceOptions` on the form; the related
// inputs live in the advanced section.
export const GpuInstanceServiceSwitch: React.FC = () => {
const intl = useIntl();
const form = Form.useFormInstance();
// The presence of `gpuInstanceOptions` on `k8s_options` is the source of
// truth for whether GPU instances are enabled. Derive the toggle directly
// from the watched form value rather than mirroring it into local state, so
// it stays in sync when the form loads async values (EDIT) or resets.
const gpuInstanceOptions = Form.useWatch(
['k8s_options', 'gpuInstanceOptions'],
form
);
// `preserve: true` makes useWatch read the full form store rather than only
// registered fields — required here because `gpuInstanceOptions` is set via
// setFieldValue and has no mounted Form.Item of its own while the switch is
// off, so a default watch would never see it flip on.
const gpuInstanceOptions = Form.useWatch(GPU_INSTANCE_OPTIONS_PATH, {
form,
preserve: true
});
const enabled = !!gpuInstanceOptions;
const handleToggle = (checked: boolean) => {
if (!form) return;
// The presence of `gpuInstanceOptions` is what signals "GPU instances
// enabled" to the backend — when on, ensure the object exists (defaulting
// to {} so it survives even when the static address is left blank); when
// off, remove it entirely.
const path = ['k8s_options', 'gpuInstanceOptions'];
// When on, ensure the object exists (defaulting to {} so it survives even
// when the static address is left blank); when off, remove it entirely.
if (checked) {
form.setFieldValue(path, form.getFieldValue(path) ?? {});
form.setFieldValue(
GPU_INSTANCE_OPTIONS_PATH,
form.getFieldValue(GPU_INSTANCE_OPTIONS_PATH) ?? {}
);
} else {
form.setFieldValue(path, undefined);
form.setFieldValue(GPU_INSTANCE_OPTIONS_PATH, undefined);
}
};
return (
<SwitchCard
styles={{
wrapper: {
borderRadius: 'var(--ant-border-radius-lg)',
paddingInline: 14,
marginBottom: 24
}
}}
value={enabled}
onChange={handleToggle}
label={intl.formatMessage({ id: 'clusters.gpuInstances.title' })}
description={intl.formatMessage({ id: 'clusters.gpuInstances.tip' })}
>
<SwitchCardWrap>
<SwitchCard
styles={{
wrapper: {
borderRadius: 'var(--ant-border-radius-lg)',
paddingInline: 14,
marginBottom: 24
}
}}
value={enabled}
onChange={handleToggle}
label={intl.formatMessage({ id: 'clusters.gpuInstances.title' })}
description={intl.formatMessage({ id: 'clusters.gpuInstances.tip' })}
/>
</SwitchCardWrap>
);
};
// Static access address for GPU instances. Only shown while the GPU instance
// service switch is on, mirroring the previous in-card behaviour. Rendered in
// the advanced section, between the default container registry and the worker
// config (节点配置).
export const GpuInstancesStaticAddressForm: React.FC = () => {
const intl = useIntl();
// See note in GpuInstanceServiceSwitch: watch the full store so this field's
// visibility tracks the switch even before it has mounted its own Form.Item.
const enabled = !!Form.useWatch(GPU_INSTANCE_OPTIONS_PATH, {
preserve: true
});
if (!enabled) {
return null;
}
return (
<SectionWrap>
<Form.Item
name={[
'k8s_options',
'gpuInstanceOptions',
'gpuInstancesAccessStaticAddress'
]}
style={{ marginBottom: 0 }}
normalize={(value) => value || null}
noStyle
>
<CInput.Input
label={intl.formatMessage({
@@ -135,23 +166,22 @@ const GpuInstanceOptionsForm: React.FC = () => {
})}
></CInput.Input>
</Form.Item>
</SwitchCard>
</SectionWrap>
);
};
const K8sPodSpec: React.FC<{
// Kubernetes-specific options that live inside the cluster's advanced section.
const K8sAdvancedOptions: React.FC<{
action: PageActionType;
}> = ({ action }) => {
return (
<>
<GpuInstanceOptionsForm />
<NamespaceForm />
<K8SVolumeMount action={action}></K8SVolumeMount>
<ImageCredential />
<NodeSelectorForm />
<OperatorImageForm />
</>
);
};
export default K8sPodSpec;
export default K8sAdvancedOptions;