From 7b2098cf33a6c6a2f582db88a678a167775216e1 Mon Sep 17 00:00:00 2001
From: jialin <jialinkuang@126.com>
Date: Wed, 9 Oct 2024 15:04:57 +0800
Subject: [PATCH] fix: playground params do not update after being  changed

---
 .../playground/components/ground-left.tsx     |  1 +
 .../playground/components/params-settings.tsx | 48 ++++++++++---------
 2 files changed, 27 insertions(+), 22 deletions(-)

diff --git a/src/pages/playground/components/ground-left.tsx b/src/pages/playground/components/ground-left.tsx
index c4e16d44..729d1fbe 100644
--- a/src/pages/playground/components/ground-left.tsx
+++ b/src/pages/playground/components/ground-left.tsx
@@ -330,6 +330,7 @@ const GroundLeft: React.FC<MessageProps> = forwardRef((props, ref) => {
         <div className="box">
           <ParamsSettings
             setParams={setParams}
+            params={parameters}
             selectedModel={selectModel}
             modelList={modelList}
           />
diff --git a/src/pages/playground/components/params-settings.tsx b/src/pages/playground/components/params-settings.tsx
index f1c8718c..cbcfedd2 100644
--- a/src/pages/playground/components/params-settings.tsx
+++ b/src/pages/playground/components/params-settings.tsx
@@ -34,7 +34,6 @@ const ParamsSettings: React.FC<ParamsSettingsProps> = ({
   setParams,
   globalParams,
   onValuesChange,
-  model,
   modelList,
   showModelSelector = true
 }) => {
@@ -80,29 +79,34 @@ const ParamsSettings: React.FC<ParamsSettingsProps> = ({
     console.log('handleOnFinishFailed', errorInfo);
   };
 
-  const handleValuesChange = (changedValues: any, allValues: any) => {
-    console.log('changedValues===', changedValues);
-    setParams?.(allValues);
-    onValuesChange?.(changedValues, allValues);
-  };
-  const handleFieldValueChange = useCallback((val: any, field: string) => {
-    const values = form.getFieldsValue();
-    form.setFieldsValue({
-      ...values,
-      [field]: val
-    });
-    setParams({
-      ...values,
-      [field]: val
-    });
-    onValuesChange?.(
-      { [field]: val },
-      {
+  const handleValuesChange = useCallback(
+    (changedValues: any, allValues: any) => {
+      setParams?.(allValues);
+      onValuesChange?.(changedValues, allValues);
+    },
+    [onValuesChange, setParams]
+  );
+  const handleFieldValueChange = useCallback(
+    (val: any, field: string) => {
+      const values = form.getFieldsValue();
+      form.setFieldsValue({
         ...values,
         [field]: val
-      }
-    );
-  }, []);
+      });
+      setParams({
+        ...values,
+        [field]: val
+      });
+      onValuesChange?.(
+        { [field]: val },
+        {
+          ...values,
+          [field]: val
+        }
+      );
+    },
+    [form, setParams, onValuesChange]
+  );
 
   const handleResetParams = () => {
     form.setFieldsValue(initialValues);