Files
goodbuddy/src/agent-daemon/agent-owned-acp-prompt.ts
T
mesalogo b90ff50f2a fix: reduce supervisor stalls and preserve task delivery
Load Supervisor graphs only when opened, preserve source details on demand, reuse indexed story digests and window selection lists without losing keyboard or focus behavior. Route heavy UI reads through the existing worker, batch scoped queries and construct each publication snapshot once.

Keep remote cancellation responsive during model-route cleanup, remove late routes and retain reported usage after response-cap cancellation. Preserve Telegram pending replies through polling conflicts, show delivery errors and honor the final rate-limit cooldown.

Schema 62 adds lookup indexes without rewriting user content; older clients cannot open upgraded data. Large review publication still blocks Main and remains documented follow-up work. Record the future storage-service direction without performing the architecture migration.

Validation: exact staged code passed isolated full tests (6212 passed, 87 skipped), typecheck and lint. Three-round source performance comparisons, SQLite migration equivalence, native Electron interaction checks and current-source Linux x64 Host validation completed; eight external text-model requests.

Release note: Supervisor opens reviews without loading the entire graph, keeps long selection lists responsive and preserves details and keyboard navigation. Remote cancellation and Telegram reply recovery are more reliable; remote fixes require an Agent build containing this change.
2026-10-05 14:18:33 +08:00

474 lines
16 KiB
TypeScript

import { createHash } from 'node:crypto'
import {
ClientSideConnection,
PROTOCOL_VERSION,
ndJsonStream,
type Client,
type McpServer,
type PromptResponse,
type RequestPermissionRequest,
type RequestPermissionResponse,
type SessionNotification
} from '@agentclientprotocol/sdk'
import { canonicalJson } from '../shared/agent-protocol/canonical'
import { remoteQuestionSchema, type RemoteQuestionResponse } from '../shared/remote-question-contracts'
import type {
RemoteOwnedPromptStartRequest,
RemoteOwnedPromptStartResult
} from '../shared/remote-agent-contracts'
import type { RuntimeAcpProcessOwner } from './runtime-acp-backend'
import { AgentAcpConnection } from './agent-acp-connection'
import { raceWithAbort } from './async-utils'
import {
SemanticPromptStore,
SemanticPromptStoreError
} from './semantic-prompt-store'
export type AgentOwnedAcpPromptOptions = {
bindingId: string
controllerId: string
workspaceDirectory: string
mcpServers?: () => McpServer[]
expectedModel?: string
process: RuntimeAcpProcessOwner
transport?: AgentAcpConnection
prepareSession?: (sessionId: string, operationId: string, signal: AbortSignal) => Promise<void>
transcript: SemanticPromptStore
completePrompt: (
operationId: string,
status: 'completed' | 'failed' | 'cancelled' | 'outcome-unknown',
response: PromptResponse | undefined,
commitTerminal: () => void
) => void | Promise<void>
resolveTerminalState?: (
proposed: 'completed' | 'failed' | 'cancelled'
) => 'completed' | 'failed' | 'cancelled' | 'outcome-unknown'
createConnection?: (
client: () => Client,
stream: ReturnType<typeof ndJsonStream>
) => ClientSideConnection
}
/**
* Owns a native Session and its original prompt Promise. Desktop connection
* signals are not part of this lifetime; the native transport may be shared.
*/
export class AgentOwnedAcpPrompt {
readonly #options: AgentOwnedAcpPromptOptions
readonly #connection: ClientSideConnection
readonly #transport: AgentAcpConnection
#unregisterSession?: () => void
readonly #processExit: Promise<never>
#sessionId?: string
#promptPromise?: Promise<void>
#promptSettled?: Promise<void>
#closed = false
#initialized = false
#starting?: {
digest: string
controller: AbortController
promise: Promise<RemoteOwnedPromptStartResult>
}
#hasMcpServers = false
readonly #questions = new Map<string, {
endpoint: string; operationId: string; questionCount: number; notification: SessionNotification
}>()
#acceptQuestions = false
#active?: {
operationId: string
}
constructor(options: AgentOwnedAcpPromptOptions) {
this.#options = options
this.#transport = options.transport ?? new AgentAcpConnection(
options.process, () => this.#client(), options.createConnection
)
this.#connection = this.#transport.connection
this.#processExit = this.#transport.exited
}
get sessionId(): string | undefined { return this.#sessionId }
async start(
request: RemoteOwnedPromptStartRequest
): Promise<RemoteOwnedPromptStartResult> {
if (this.#closed) throw new Error('ACP Session is closed')
if (
request.bindingId !== this.#options.bindingId
) {
throw new SemanticPromptStoreError(
'Owned ACP prompt identity does not match its preparation',
'conflict'
)
}
const startDigest = digest(canonicalJson(request))
if (this.#starting) {
if (this.#starting.digest !== startDigest) {
throw new SemanticPromptStoreError('Another ACP prompt is starting', 'conflict')
}
return this.#starting.promise
}
const existing = this.#options.transcript.findStarted({
bindingId: request.bindingId,
operationId: request.operationId,
controllerId: this.#options.controllerId,
startDigest
})
if (existing !== undefined) {
return existing
}
if (this.#active !== undefined) {
throw new SemanticPromptStoreError(
'Another ACP prompt is still active',
'conflict'
)
}
const controller = new AbortController()
const promise = this.#start(request, startDigest, controller.signal)
this.#starting = { digest: startDigest, controller, promise }
try {
return await promise
} finally {
this.#starting = undefined
}
}
async #start(
request: RemoteOwnedPromptStartRequest,
startDigest: string,
signal: AbortSignal
): Promise<RemoteOwnedPromptStartResult> {
const whileStarting = async <T>(operation: Promise<T>): Promise<T> => {
const result = await raceWithAbort(this.#whileProcessAlive(operation), signal)
signal.throwIfAborted()
return result
}
const retainSession = async (operation: Promise<string>): Promise<string> =>
whileStarting(operation.then(sessionId => {
if (signal.aborted) {
// A native session can be created after its owner was cancelled.
void this.#connection.closeSession({ sessionId }).catch(() => undefined)
} else {
this.#sessionId = sessionId
}
return sessionId
}))
const mcpServers = this.#options.mcpServers?.() ?? []
if (!this.#initialized) {
const initialization = await whileStarting(
this.#transport.initialize({
protocolVersion: PROTOCOL_VERSION,
clientCapabilities: {
terminal: false,
fs: {
readTextFile: false,
writeTextFile: false
}
},
clientInfo: {
name: 'GoodBuddy Agent',
version: '1'
}
})
)
if (initialization.protocolVersion !== PROTOCOL_VERSION) {
throw new Error('ACP Runtime protocol version is incompatible')
}
if (request.acpSessionId !== undefined && this.#sessionId === undefined) {
if (initialization.agentCapabilities?.loadSession === true) {
this.#sessionId = await retainSession(
this.#connection.loadSession({
sessionId: request.acpSessionId,
cwd: this.#options.workspaceDirectory,
mcpServers
}).then(() => request.acpSessionId!)
)
} else if (
initialization.agentCapabilities?.sessionCapabilities?.resume != null
) {
this.#sessionId = await retainSession(
this.#connection.resumeSession({
sessionId: request.acpSessionId,
cwd: this.#options.workspaceDirectory,
mcpServers
}).then(() => request.acpSessionId!)
)
} else {
throw new Error('ACP Runtime cannot resume the requested session')
}
} else if (this.#sessionId === undefined) {
this.#sessionId = await retainSession(
this.#connection.newSession({
cwd: this.#options.workspaceDirectory,
mcpServers
}).then(created => created.sessionId)
)
}
if (this.#options.expectedModel !== undefined) {
const configured = await whileStarting(
this.#connection.setSessionConfigOption({
sessionId: this.#sessionId!,
configId: 'model',
value: this.#options.expectedModel
})
)
const selectedModel = configured.configOptions.find(
(option) => option.id === 'model' && option.type === 'select'
)
if (
selectedModel === undefined ||
selectedModel.currentValue !== this.#options.expectedModel
) {
throw new Error('ACP Runtime did not select the prepared model')
}
}
this.#unregisterSession = this.#transport.register(this.#sessionId!, this.#client())
this.#initialized = true
} else if (
request.acpSessionId !== undefined &&
request.acpSessionId !== this.#sessionId
) {
throw new Error('ACP session identity cannot change within a binding')
} else if (mcpServers.length > 0 || this.#hasMcpServers) {
await whileStarting(this.#connection.resumeSession({
sessionId: this.#sessionId!, cwd: this.#options.workspaceDirectory,
mcpServers
}))
}
this.#hasMcpServers = mcpServers.length > 0
await whileStarting(Promise.resolve(this.#options.prepareSession?.(this.#sessionId!, request.operationId, signal)))
signal.throwIfAborted()
this.#active = {
operationId: request.operationId
}
this.#acceptQuestions = true
const begun = this.#options.transcript.begin({
bindingId: this.#options.bindingId,
operationId: request.operationId,
startDigest,
sessionId: this.#sessionId!
})
// Keep this exact Promise alive on Agent. The caller receives only the
// durable operation identity and may disconnect immediately.
const promptOperation = this.#whileProcessAlive(
this.#connection.prompt({
sessionId: this.#sessionId!,
prompt: request.prompt
})
)
this.#promptSettled = promptOperation.then(() => undefined, () => undefined)
const finish = async (proposed: 'completed' | 'failed' | 'cancelled', response?: PromptResponse, error?: unknown) => {
let state = this.#options.resolveTerminalState?.(proposed) ?? proposed
let completionError: unknown
let committed = false
const commitTerminal = () => {
if (committed) return
this.#appendTerminal(state, {
status: state,
...(response === undefined ? { error: boundedError(error) } : { response }),
...(completionError === undefined ? {} : { completionError: boundedError(completionError) })
})
committed = true
}
try {
await this.#options.completePrompt(request.operationId, state, response, commitTerminal)
} catch (error) {
state = 'outcome-unknown'
completionError = error
}
commitTerminal()
}
this.#promptPromise = promptOperation.then(
response => finish(response.stopReason === 'cancelled' ? 'cancelled' : 'completed', response),
error => finish('failed', undefined, error)
)
.finally(() => {
this.#questions.clear()
this.#acceptQuestions = false
this.#active = undefined
})
void this.#promptPromise.catch(() => undefined)
return begun.result
}
async cancel(): Promise<void> {
this.#starting?.controller.abort(new Error('ACP prompt startup cancelled'))
this.#acceptQuestions = false
this.#questions.clear()
if (this.#sessionId !== undefined && !this.#closed) {
await this.#connection.cancel({ sessionId: this.#sessionId })
}
}
close(): void {
this.#clear()
}
async releaseSession(): Promise<void> {
await this.cancel()
if (this.#sessionId && !this.#closed) {
await this.#connection.closeSession({ sessionId: this.#sessionId })
}
// Wait for the original native Prompt, not its completion callback, which
// may be queued behind the caller's backend control operation.
await this.#promptSettled
this.close()
}
async respondToQuestion(request: RemoteQuestionResponse): Promise<void> {
const pending = this.#questions.get(request.questionId)
if (this.#closed || !pending || this.#active?.operationId !== request.operationId ||
pending.operationId !== request.operationId || request.bindingId !== this.#options.bindingId) {
throw new Error('Remote question is no longer pending for this prompt')
}
if (request.answers.length !== 0 && request.answers.length !== pending.questionCount) {
throw new Error('Question answer count does not match')
}
const response = await fetch(pending.endpoint, {
method: 'POST', headers: { 'content-type': 'application/json' },
body: JSON.stringify({ ...request, sessionId: this.#sessionId }),
signal: AbortSignal.timeout(30_000), redirect: 'error'
})
if (!response.ok) throw new Error(`OpenCode question response failed (${response.status})`)
this.#questions.delete(request.questionId)
}
pendingQuestions(operationId: string): SessionNotification[] {
if (!this.#acceptQuestions || this.#active?.operationId !== operationId) return []
return [...this.#questions.values()].map(question => question.notification)
}
#client(): Client {
return {
requestPermission: async (request) =>
this.#handlePermission(request),
sessionUpdate: async (notification) => {
this.#handleSessionUpdate(notification)
},
extMethod: async () => ({}),
extNotification: async () => undefined
}
}
#handleSessionUpdate(notification: SessionNotification): void {
if (this.#closed || !this.#active) return
if (
notification.sessionId !== this.#sessionId &&
this.#sessionId !== undefined
) {
throw new Error('ACP session notification identity changed')
}
const resolved = notification.update._meta?.goodbuddyQuestionResolved
if (typeof resolved === 'string') {
this.#questions.delete(resolved)
return
}
const extension = notification.update._meta?.goodbuddyQuestion
if (extension !== undefined) {
if (!this.#acceptQuestions) return
if (!extension || typeof extension !== 'object') throw new Error('Invalid remote question')
const value = extension as { question?: unknown; endpoint?: unknown; childCallId?: unknown }
const question = remoteQuestionSchema.parse(value.question)
if (typeof value.endpoint !== 'string' ||
!/^http:\/\/127\.0\.0\.1:\d+\/[A-Za-z0-9_-]{43}$/u.test(value.endpoint)) {
throw new Error('Invalid remote question endpoint')
}
if (this.#questions.has(question.id)) return
// The process-local reply capability never enters the durable transcript.
notification = { ...notification, update: {
...notification.update, _meta: { goodbuddyQuestion: {
question, ...(typeof value.childCallId === 'string' ? { childCallId: value.childCallId } : {})
} }
} }
this.#questions.set(question.id, { endpoint: value.endpoint, operationId: this.#active.operationId,
questionCount: question.questions.length, notification })
}
this.#options.transcript.append({
bindingId: this.#options.bindingId,
operationId: this.#requireActive().operationId,
kind: 'session-update',
payload: notification
})
}
#handlePermission(
request: RequestPermissionRequest
): RequestPermissionResponse {
const active = this.#requireActive()
const selected =
request.options.find((option) => option.kind === 'allow_once') ??
request.options.find((option) => option.kind === 'allow_always')
const response: RequestPermissionResponse =
selected === undefined
? { outcome: { outcome: 'cancelled' } }
: {
outcome: {
outcome: 'selected',
optionId: selected.optionId
}
}
this.#options.transcript.append({
bindingId: this.#options.bindingId,
operationId: active.operationId,
kind: 'permission-decision',
payload: {
sessionId: request.sessionId,
toolCallId: request.toolCall.toolCallId,
outcome: response.outcome
}
})
return response
}
#appendTerminal(
state: 'completed' | 'failed' | 'cancelled' | 'outcome-unknown',
payload: unknown
): void {
this.#options.transcript.append({
bindingId: this.#options.bindingId,
operationId: this.#requireActive().operationId,
kind: 'prompt-terminal',
payload,
terminalState: state
})
}
#clear(): void {
if (this.#closed) {
return
}
this.#closed = true
this.#starting?.controller.abort(new Error('ACP Session is closed'))
this.#acceptQuestions = false
this.#questions.clear()
this.#unregisterSession?.()
if (!this.#options.transport) this.#transport.dispose()
}
async #whileProcessAlive<T>(operation: Promise<T>): Promise<T> {
return await Promise.race([operation, this.#processExit])
}
#requireActive(): { operationId: string } {
if (this.#active === undefined) {
throw new Error('ACP notification has no active prompt')
}
return this.#active
}
}
function digest(value: string): string {
return `sha256:${createHash('sha256').update(value).digest('hex')}`
}
function boundedError(error: unknown): { name: string; message: string } {
const name =
error instanceof Error ? error.name.slice(0, 256) : 'Error'
const message =
error instanceof Error
? error.message.slice(0, 8 * 1024)
: 'ACP prompt failed'
return { name, message }
}