Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
129 lines
3.2 KiB
TypeScript
129 lines
3.2 KiB
TypeScript
import type { EmbeddingIndexStatus } from '../../shared/embedding-contracts'
|
|
import type {
|
|
EmbeddingIndexRecord,
|
|
EmbeddingIndexRepository
|
|
} from './embedding-index-coordinator'
|
|
import type { KnowledgeStoragePort } from './knowledge-storage-port'
|
|
|
|
export class KnowledgeEmbeddingIndexRepository
|
|
implements EmbeddingIndexRepository {
|
|
constructor(
|
|
private readonly database: Pick<KnowledgeStoragePort,
|
|
'getLastEmbeddingIndexJob' | 'saveEmbeddingIndexJob' |
|
|
'listEmbeddingIndexDocumentIds' | 'getEmbeddingIndexDocument' |
|
|
'beginDocumentEmbeddingReplacement' | 'appendDocumentEmbeddingBatch' |
|
|
'finishDocumentEmbeddingReplacement' | 'discardDocumentEmbeddingReplacement' |
|
|
'recordEmbeddingIndexError'>,
|
|
private readonly knowledgeBaseId: string
|
|
) {}
|
|
|
|
async getLastJob(): Promise<EmbeddingIndexStatus['job']> {
|
|
return await this.database.getLastEmbeddingIndexJob(this.knowledgeBaseId)
|
|
}
|
|
|
|
async saveStatus(status: EmbeddingIndexStatus): Promise<void> {
|
|
await this.database.saveEmbeddingIndexJob(
|
|
this.knowledgeBaseId,
|
|
status.job
|
|
)
|
|
}
|
|
|
|
async listIndexDocumentIds(signal: AbortSignal) {
|
|
signal.throwIfAborted()
|
|
const documentIds =
|
|
await this.database.listEmbeddingIndexDocumentIds(
|
|
this.knowledgeBaseId
|
|
)
|
|
signal.throwIfAborted()
|
|
return documentIds
|
|
}
|
|
|
|
async getIndexDocument(
|
|
documentId: string,
|
|
signal: AbortSignal
|
|
) {
|
|
signal.throwIfAborted()
|
|
const document =
|
|
await this.database.getEmbeddingIndexDocument(documentId)
|
|
signal.throwIfAborted()
|
|
return document
|
|
}
|
|
|
|
async beginDocumentReplacement(
|
|
documentId: string,
|
|
provider: string,
|
|
model: string,
|
|
signal: AbortSignal
|
|
): Promise<string> {
|
|
signal.throwIfAborted()
|
|
const replacementId =
|
|
await this.database.beginDocumentEmbeddingReplacement(
|
|
documentId,
|
|
provider,
|
|
model
|
|
)
|
|
return replacementId
|
|
}
|
|
|
|
async appendDocumentReplacement(
|
|
replacementId: string,
|
|
documentId: string,
|
|
provider: string,
|
|
model: string,
|
|
records: readonly EmbeddingIndexRecord[],
|
|
signal: AbortSignal
|
|
): Promise<void> {
|
|
signal.throwIfAborted()
|
|
await this.database.appendDocumentEmbeddingBatch(
|
|
replacementId,
|
|
documentId,
|
|
provider,
|
|
model,
|
|
records.map((record) => ({
|
|
chunkId: record.itemId,
|
|
contentChecksum: record.contentChecksum ?? '',
|
|
vector: record.vector
|
|
}))
|
|
)
|
|
signal.throwIfAborted()
|
|
}
|
|
|
|
async finishDocumentReplacement(
|
|
replacementId: string,
|
|
documentId: string,
|
|
provider: string,
|
|
model: string,
|
|
signal: AbortSignal
|
|
): Promise<void> {
|
|
signal.throwIfAborted()
|
|
await this.database.finishDocumentEmbeddingReplacement(
|
|
replacementId,
|
|
documentId,
|
|
provider,
|
|
model
|
|
)
|
|
}
|
|
|
|
async discardDocumentReplacement(
|
|
replacementId: string
|
|
): Promise<void> {
|
|
await this.database.discardDocumentEmbeddingReplacement(
|
|
replacementId
|
|
)
|
|
}
|
|
|
|
async recordDocumentError(
|
|
documentId: string,
|
|
provider: string,
|
|
model: string,
|
|
error: string
|
|
): Promise<void> {
|
|
await this.database.recordEmbeddingIndexError(
|
|
documentId,
|
|
provider,
|
|
model,
|
|
error
|
|
)
|
|
}
|
|
}
|