Files
goodbuddy/src/main/assistant/assistant-storage-upgrade.ts
T
mesalogo 4c7193e1ea fix: avoid history reclamation during structure-only upgrades
Ordinary database schema upgrades previously ran VACUUM on free pages and
showed misleading history-cleanup progress. Separate structure upgrades from
required legacy conversions, retaining reclamation intent only for retries
within the same startup. Preserve released data without new schema versions
or persistent migration markers; Agent and normal writes remain unchanged.

Add real SQLite and Worker regressions, bilingual operation-specific startup
copy, and migration documentation. Synchronize native Electron drag input
with actual resize state without weakening layout assertions.

Validation: 47 focused migration tests passed; typecheck, lint and diff checks
passed. Final full suite: 5137 passed, 74 skipped, 2 unrelated Electron failures.
Both failing Electron tests passed an isolated rerun; full CI remains unverified.

Release note: 修复普通数据库结构升级再次整理历史和回收空间的问题;仅在需要转换旧数据时执行相关处理,启动页准确显示当前升级操作。
2026-09-26 12:42:08 +08:00

174 lines
6.4 KiB
TypeScript

import { statSync } from 'node:fs'
import { DatabaseSync } from 'node:sqlite'
import type { ConversationMessageBlock } from '../../shared/assistant-contracts'
import type { AssistantStorageProgress } from '../../shared/assistant-storage-contracts'
import {
ASSISTANT_DATABASE_SCHEMA_VERSION,
AssistantDatabase
} from './assistant-database'
import {
compactSubagentPayload,
restoreSubagentPayload,
SUBAGENT_PROGRESS_STORAGE_SCHEMA_VERSION
} from './subagent-progress-storage'
export type AssistantStorageUpgrade = {
migrateNotes: boolean
reclaimSpace: boolean
}
export function getPendingAssistantStorageUpgrade(
databasePath: string
): AssistantStorageUpgrade | undefined {
const database = new DatabaseSync(databasePath, {
readOnly: true,
timeout: 5_000
})
try {
const row = database.prepare('PRAGMA user_version').get() as {
user_version: number
}
const noteTable = database.prepare(
`SELECT 1
FROM sqlite_master
WHERE type = 'table' AND name = 'magic_note_entries'
LIMIT 1`
).get()
const migrateNotes = Boolean(noteTable && database.prepare(
`SELECT 1
FROM magic_note_entries
WHERE json_extract(content_json, '$.storage') IS NULL
OR json_extract(content_json, '$.storage') <> 'file'
LIMIT 1`
).get())
if (row.user_version >= ASSISTANT_DATABASE_SCHEMA_VERSION && !migrateNotes) return undefined
// Reclamation belongs to specific released data conversions, not every schema bump.
const legacySubagents = row.user_version > 0 &&
row.user_version < SUBAGENT_PROGRESS_STORAGE_SCHEMA_VERSION &&
Boolean(database.prepare("SELECT 1 FROM task_events WHERE kind = 'subagent' LIMIT 1").get())
const legacyActivity = row.user_version > 0 && row.user_version < 44 &&
Boolean(database.prepare("SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'activity_history'").get()) &&
Boolean(database.prepare("SELECT 1 FROM activity_history WHERE records_json <> '[]' LIMIT 1").get())
return { migrateNotes, reclaimSpace: migrateNotes || legacySubagents || legacyActivity }
} finally {
database.close()
}
}
export function hasPendingAssistantStorageUpgrade(databasePath: string): boolean {
return getPendingAssistantStorageUpgrade(databasePath) !== undefined
}
export function upgradeAssistantStorage(
databasePath: string,
onProgress: (progress: AssistantStorageProgress) => void,
isCancelled: () => boolean = () => false,
options: { confirmedUpgrade?: AssistantStorageUpgrade } = {}
): void {
const upgrade = options.confirmedUpgrade ?? getPendingAssistantStorageUpgrade(databasePath)
if (!upgrade) return
if (isCancelled()) throw new DOMException('Upgrade cancelled', 'AbortError')
upgradeSubagentStorage(databasePath, onProgress, isCancelled)
onProgress({ stage: 'upgrading', processed: 0, total: 0, bytesBefore: statSync(databasePath).size })
if (isCancelled()) throw new DOMException('Upgrade cancelled', 'AbortError')
new AssistantDatabase(databasePath).upgradeStorage(onProgress, isCancelled, upgrade)
}
function upgradeSubagentStorage(
databasePath: string,
onProgress: (progress: AssistantStorageProgress) => void,
isCancelled: () => boolean = () => false
): void {
const database = new DatabaseSync(databasePath, { timeout: 5_000 })
const checkCancelled = (): void => {
if (isCancelled()) throw new DOMException('Upgrade cancelled', 'AbortError')
}
const bytesBefore = statSync(databasePath).size
try {
const version = database.prepare('PRAGMA user_version').get() as {
user_version: number
}
if (
version.user_version < 1 ||
version.user_version >= SUBAGENT_PROGRESS_STORAGE_SCHEMA_VERSION
) return
checkCancelled()
const progress: AssistantStorageProgress = {
stage: 'scanning', processed: 0, total: 0, bytesBefore
}
onProgress({ ...progress })
database.exec(`
PRAGMA journal_mode = WAL;
PRAGMA busy_timeout = 5000;
PRAGMA secure_delete = OFF;
PRAGMA cache_size = -65536;
CREATE INDEX IF NOT EXISTS task_events_subagent_idx
ON task_events(task_id, id) WHERE kind = 'subagent';
`)
const tasks = database.prepare(
`SELECT task_id, COUNT(*) AS count FROM task_events
WHERE kind = 'subagent' GROUP BY task_id`
).all() as Array<{ task_id: string; count: number }>
progress.total = tasks.reduce((sum, task) => sum + task.count, 0)
progress.stage = 'converting'
const select = database.prepare(
`SELECT id, payload_json FROM task_events
WHERE task_id = ? AND kind = 'subagent' AND id > ?
ORDER BY id LIMIT 32`
)
const update = database.prepare(
'UPDATE task_events SET payload_json = ? WHERE id = ?'
)
for (const task of tasks) {
const blocks = new Map<string, ConversationMessageBlock[]>()
let afterId = 0
for (;;) {
checkCancelled()
const rows = select.all(task.task_id, afterId) as Array<{
id: number; payload_json: string
}>
if (!rows.length) break
database.exec('BEGIN IMMEDIATE')
try {
for (const row of rows) {
const payload: unknown = JSON.parse(row.payload_json)
const compact = compactSubagentPayload(payload, blocks)
// Replay mixed old/new rows on retry. Never delete events or provenance.
restoreSubagentPayload(payload, blocks)
const compactJson = JSON.stringify(compact)
if (compactJson !== row.payload_json) {
update.run(compactJson, row.id)
}
afterId = row.id
}
database.exec('COMMIT')
} catch (error) {
database.exec('ROLLBACK')
throw error
}
progress.processed += rows.length
onProgress({ ...progress })
}
database.exec('PRAGMA wal_checkpoint(TRUNCATE)')
}
checkCancelled()
const free = database.prepare('PRAGMA freelist_count').get() as {
freelist_count: number
}
if (tasks.length > 0 && free.freelist_count > 0) {
progress.stage = 'compacting'
onProgress({ ...progress })
// Rebuild the now-small live database, not a second copy of the bloated input.
database.exec('PRAGMA wal_checkpoint(TRUNCATE); VACUUM;')
database.exec('PRAGMA wal_checkpoint(TRUNCATE)')
}
checkCancelled()
onProgress({
...progress, stage: 'complete',
bytesAfter: statSync(databasePath).size
})
} finally {
database.close()
}
}