Files
goodbuddy/src/main/remote-agent/remote-agent-services.ts
T
mesalogo 2833a27f83 feat: add bounded diagnostics and improve UX feedback
Ask and Execute guidance, Runtime state, live announcements, loading states,
retry paths, settings focus, and update failures now provide consistent and
accessible feedback across the desktop experience.

Add bounded redacted Desktop and Agent diagnostic logs, a read-only Agent
diagnostics command, and an explicit opt-in for attaching a small Desktop
diagnostic summary to in-app feedback. Diagnostics stay local by default and
the existing feedback v1 service contract remains compatible.

Release note: 新增可选桌面诊断反馈与 Agent 诊断导出,并统一 Ask/Execute 状态、错误恢复和无障碍反馈;诊断默认保留在本地,仅在用户明确勾选时附加桌面摘要。
2026-08-31 15:35:13 +08:00

157 lines
5.1 KiB
TypeScript

import { join } from 'node:path'
import { SshConnectionPool } from '../ssh/ssh-connection-pool'
import type { SshHostStore } from '../ssh/ssh-host-store'
import { AgentInstallationManager } from './agent-installation-manager'
import {
resolveBundledAgentResourcePaths,
type BundledAgentResourcePaths
} from './bundled-agent-resources'
import {
ControllerStateStore,
JsonControllerStateFile
} from './controller-state-store'
import {
RemoteAgentConnectionManager,
type RemoteAgentTargetResolver
} from './remote-agent-connection-manager'
import type {
DesktopDiagnosticFailureObserver
} from '../desktop-diagnostics'
const CONTROLLER_STATE_FILE_NAME = 'remote-agent-controller-state.json'
type RemoteAgentServiceFactories = {
createSshConnectionPool: (options: {
controlPlanePackageInstaller: Buffer | string
}) => SshConnectionPool
createControllerStateStore: (
filePath: string
) => ControllerStateStore
createAgentInstallationManager: (options: {
resolver: RemoteAgentTargetResolver
sshPool: SshConnectionPool
resourcePaths: BundledAgentResourcePaths
}) => AgentInstallationManager
createConnectionManager: (options: {
resolver: RemoteAgentTargetResolver
sshPool: SshConnectionPool
controllerState: ControllerStateStore
goodBuddyVersion: string
observeFailure?: DesktopDiagnosticFailureObserver
}) => RemoteAgentConnectionManager
}
export type RemoteAgentServicesOptions = {
sshHostStore: SshHostStore
goodBuddyVersion: string
userDataPath: string
appPath: string
resourcesPath: string
packaged: boolean
controlPlanePackageInstaller: Buffer | string
observeFailure?: DesktopDiagnosticFailureObserver
factories?: Partial<RemoteAgentServiceFactories>
}
/**
* Main-process lifecycle owner for the dormant remote Agent control plane.
* Construction only composes local objects and paths; network, disk, bundle
* verification, and installation work remain lazy until an explicit caller
* uses the corresponding service.
*/
export class RemoteAgentServices {
readonly targetResolver: RemoteAgentTargetResolver
readonly resourcePaths: BundledAgentResourcePaths
readonly sshPool: SshConnectionPool
readonly controllerState: ControllerStateStore
readonly installationManager: AgentInstallationManager
readonly connectionManager: RemoteAgentConnectionManager
#disposePromise: Promise<void> | undefined
constructor(options: RemoteAgentServicesOptions) {
const factories: RemoteAgentServiceFactories = {
createSshConnectionPool: (poolOptions) =>
new SshConnectionPool(undefined, poolOptions),
createControllerStateStore: (filePath) =>
new ControllerStateStore(new JsonControllerStateFile(filePath)),
createAgentInstallationManager: (managerOptions) =>
new AgentInstallationManager(managerOptions),
createConnectionManager: (managerOptions) =>
new RemoteAgentConnectionManager(managerOptions),
...options.factories
}
this.targetResolver = {
resolve: (hostId) =>
options.sshHostStore.resolveConnectionTarget(hostId)
}
this.resourcePaths = resolveBundledAgentResourcePaths({
appPath: options.appPath,
resourcesPath: options.resourcesPath,
packaged: options.packaged
})
this.sshPool = factories.createSshConnectionPool({
controlPlanePackageInstaller:
options.controlPlanePackageInstaller
})
this.controllerState = factories.createControllerStateStore(
join(options.userDataPath, CONTROLLER_STATE_FILE_NAME)
)
this.installationManager =
factories.createAgentInstallationManager({
resolver: this.targetResolver,
sshPool: this.sshPool,
resourcePaths: this.resourcePaths
})
this.connectionManager = factories.createConnectionManager({
resolver: this.targetResolver,
sshPool: this.sshPool,
controllerState: this.controllerState,
goodBuddyVersion: options.goodBuddyVersion,
observeFailure: options.observeFailure
})
}
/**
* Invalidates live and persisted controller state. The connection manager
* closes matching connections and pool entries before its first await, so a
* credential-free SSH host lifecycle hook starts fail-closed synchronously.
*/
invalidateHost(hostId: string): Promise<void> {
this.installationManager.invalidateHost(hostId)
return this.connectionManager.invalidateHost(hostId)
}
dispose(): Promise<void> {
this.#disposePromise ??= this.#dispose()
return this.#disposePromise
}
async #dispose(): Promise<void> {
const errors: unknown[] = []
const settle = async (
operation: () => void | Promise<void>
): Promise<void> => {
try {
await operation()
} catch (error) {
errors.push(error)
}
}
await settle(() => this.installationManager.dispose())
await settle(() => this.connectionManager.dispose())
await settle(() => this.controllerState.flush())
await settle(() => this.controllerState.dispose())
await settle(() => this.sshPool.dispose())
if (errors.length > 0) {
throw new AggregateError(
errors,
'Remote Agent services failed to dispose completely'
)
}
}
}