Files
goodbuddy/src/main/readonly-query-worker.ts
T
mesalogo d80d42b032 feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.

- Remove the Main readWithFallback path and the supervision worker's
  separate business write connection; manifests are scanned read-only and
  committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
  unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
  ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
  storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
  directories and reclaim confirmed stale ones; stop writing duplicate
  parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
  acceptance fixtures, and maintenance/architecture documentation.

Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
2026-10-06 15:40:18 +08:00

135 lines
6.6 KiB
TypeScript

import { parentPort, workerData } from 'node:worker_threads'
import { z } from 'zod'
import { AssistantDatabase } from './assistant/assistant-database'
import { KnowledgeDatabase } from './knowledge/knowledge-database'
import type { ReadonlyQueryKind, ReadonlyQueryRequest } from './readonly-query-reader'
import type { ReviewRevisionRow, ReviewState } from './assistant/supervision-review-store'
// Read-only query worker (PERF-15/16 first slice). One worker per database file.
// It reuses the production classes on a read-only connection, so results are
// produced by exactly the same code as the synchronous path.
// This packaged entry also hosts the WAL checkpointer. Supervision manifests
// are scanned read-only and transferred in pages to their sole business writer.
const { kind, databasePath, intervalMs } = workerData as {
kind: ReadonlyQueryKind | 'checkpoint'
databasePath: string
intervalMs?: number
}
type Handler = (args: unknown[], signal: AbortSignal) => unknown
let handlers: Record<string, Handler>
let close: () => void
if (kind === 'checkpoint') {
// Storage-owner-managed PASSIVE checkpoints never wait for business writers.
const database = new AssistantDatabase(databasePath)
database.openCheckpointer()
const timer = setInterval(() => {
try {
database.checkpointWal()
} catch {
// SQLITE_BUSY and similar: try again on the next tick.
}
}, intervalMs ?? 1_000)
close = () => {
clearInterval(timer)
database.close()
}
handlers = {}
parentPort!.postMessage({ ready: true })
} else if (kind === 'knowledge') {
const database = new KnowledgeDatabase(databasePath)
database.openReadOnly()
close = () => database.close()
handlers = {
search: ([options]) => database.search(options as Parameters<KnowledgeDatabase['search']>[0]),
vectorSearch: ([options], signal) => database.vectorSearch({ ...(options as Parameters<KnowledgeDatabase['vectorSearch']>[0]), signal }),
graphSearch: args => database.graphSearch(...args as Parameters<KnowledgeDatabase['graphSearch']>),
hybridSearchWithDiagnostics: ([options], signal) => database.hybridSearchWithDiagnostics({
...(options as Parameters<KnowledgeDatabase['hybridSearchWithDiagnostics']>[0]), signal
})
}
} else {
const database = new AssistantDatabase(databasePath)
database.openReadOnly()
close = () => database.close()
let manifestRunId: string | undefined
handlers = {
reviewManifestScan: ([runId, state], signal) => {
if (manifestRunId !== undefined) throw new Error('Review manifest reader is busy')
manifestRunId = String(runId)
try { database.supervisionReviewStore(signal).createSourceManifest(state as ReviewState, signal) }
catch (error) { manifestRunId = undefined; throw error }
},
reviewManifestPage: ([runId, offset]) => {
if (manifestRunId !== runId) throw new Error('Review manifest reader lost its snapshot; resume initialization')
return database.supervisionReviewStore().sourceManifestPage(Number(offset))
},
reviewManifestRelease: ([runId]) => {
if (manifestRunId !== runId) return
database.supervisionReviewStore().releaseSourceManifest()
manifestRunId = undefined
},
reviewChangedSource: ([rows], signal) => database.readSnapshot(() =>
database.supervisionReviewStore(signal).changedSource(rows as ReviewRevisionRow[], signal)),
readStoryGraph: ([name, input, projectId], signal) => database.readStoryGraph(
name as Parameters<AssistantDatabase['readStoryGraph']>[0], input, projectId as string | undefined, signal),
supervisionOverview: ([limit, target, resultId]) => database.readSnapshot(() => database.listSupervisionResults(
limit as number, target as Parameters<AssistantDatabase['listSupervisionResults']>[1], resultId as string | undefined)),
supervisionGraph: ([input]) => database.readSnapshot(() => database.getSupervisionGraph(input as Parameters<AssistantDatabase['getSupervisionGraph']>[0])),
supervisionStories: ([scope]) => database.readSnapshot(() => database.getSupervisionStories(scope as ReviewState['request']['scope'])),
searchConversations: ([query]) => database.searchConversations(query as string),
// Several statements each: read them from one snapshot.
listConversationSummaries: ([detailIds]) => database.readSnapshot(() =>
database.listConversationSummaries(detailIds as string[])),
getConversation: ([conversationId]) => database.readSnapshot(() =>
database.getConversation(conversationId as string)),
activityHistoryPage: ([input]) => database.getActivityHistoryPage(input),
activityHistorySummary: ([input]) => database.getActivityHistorySummary(input),
reviewContext: ([request]) => {
const scope = (request as ReviewState['request']).scope
return database.readSnapshot(() => ({ summary: database.reviewSummary(scope, 'supervisor'), background: database.reviewBackground(scope) }))
},
reviewCandidates: ([request, batch]) => database.listSupervisionCandidates(request as ReviewState['request'],
batch as Parameters<AssistantDatabase['listSupervisionCandidates']>[1])
}
}
/** A signal backed by the shared cancel flag; queries poll it via throwIfAborted(). */
function sharedSignal(cancel: SharedArrayBuffer): AbortSignal {
const flag = new Int32Array(cancel)
const reason = (): Error => Object.assign(new Error('This operation was aborted'), { name: 'AbortError' })
const signal = new AbortController().signal
Object.defineProperties(signal, {
aborted: { get: () => Atomics.load(flag, 0) === 1 },
reason: { get: () => (Atomics.load(flag, 0) === 1 ? reason() : undefined) },
throwIfAborted: { value: () => { if (Atomics.load(flag, 0) === 1) throw reason() } }
})
return signal
}
function serializeError(error: unknown): { name: string; message: string; issues?: unknown } {
if (error instanceof z.ZodError) return { name: 'ZodError', message: error.message, issues: error.issues }
if (error instanceof Error) return { name: error.name, message: error.message }
return { name: 'Error', message: String(error) }
}
parentPort!.on('message', (message: ReadonlyQueryRequest | { type: 'close' }) => {
if (message.type === 'close') {
close()
parentPort!.close()
return
}
try {
const handler = Object.hasOwn(handlers, message.op) ? handlers[message.op] : undefined
if (!handler) throw new Error(`Unknown readonly query: ${message.op}`)
const signal = sharedSignal(message.cancel)
signal.throwIfAborted()
parentPort!.postMessage({ id: message.id, result: handler(message.args, signal) })
} catch (error) {
parentPort!.postMessage({ id: message.id, error: serializeError(error) })
}
})
parentPort!.on('close', () => close())