Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
36 lines
1.8 KiB
TypeScript
36 lines
1.8 KiB
TypeScript
import type { DesktopStorageClient } from './desktop-storage-client'
|
|
import { assistantStorageMethods, type StorageArgs, type StorageChange, type StorageMethod, type StorageResult } from './desktop-storage-contracts'
|
|
|
|
export type Awaitable<T> = T | Promise<T>
|
|
export type AssistantStorageMethod = StorageMethod<'assistant'>
|
|
// Borrowed domain consumers use ordinary repository methods. SSH save orchestration
|
|
// has its own data-only port; those composites remain on the full async facade.
|
|
export type AssistantStoragePort = {
|
|
[M in Exclude<AssistantStorageMethod, 'createSshProject' | 'updateSshProject' | 'supervisionContext'>]: (...args: StorageArgs<'assistant', M>) => Awaitable<StorageResult<'assistant', M>>
|
|
}
|
|
export type AsyncAssistantStoragePort = {
|
|
[M in AssistantStorageMethod]: (...args: StorageArgs<'assistant', M>) => Promise<StorageResult<'assistant', M>>
|
|
}
|
|
|
|
/** Only named data operations are bound; callbacks and repositories stay local. */
|
|
export function createAssistantStoragePort(client: Pick<DesktopStorageClient, 'call'>): AsyncAssistantStoragePort {
|
|
return Object.fromEntries([...assistantStorageMethods, 'supervisionContext' as const].map(method => [
|
|
method, (...args: StorageArgs<'assistant', typeof method>) => client.call('assistant', method, args)
|
|
])) as AsyncAssistantStoragePort
|
|
}
|
|
|
|
export function createAssistantStorageOnChanged(callbacks: {
|
|
onMagicNotesChanged?: () => void
|
|
onMagicTodosChanged?: () => void
|
|
onModelUsageChanged?: () => void
|
|
onExecutionStatsChanged?: () => void
|
|
}): (domain: StorageChange) => void {
|
|
const listeners = {
|
|
magicNotes: callbacks.onMagicNotesChanged,
|
|
magicTodos: callbacks.onMagicTodosChanged,
|
|
modelUsage: callbacks.onModelUsageChanged,
|
|
executionStats: callbacks.onExecutionStatsChanged
|
|
}
|
|
return domain => listeners[domain]?.()
|
|
}
|