feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
@@ -0,0 +1,29 @@
|
||||
import { KnowledgeService, type KnowledgeServiceOptions } from '../../src/main/knowledge/knowledge-service'
|
||||
import { KnowledgeDatabase } from '../../src/main/knowledge/knowledge-database'
|
||||
import { createKnowledgeStoragePort } from '../../src/main/knowledge/knowledge-storage-port'
|
||||
import { publishStorageDocument } from '../../src/main/desktop-storage-publication'
|
||||
import { replaceDocumentGraph } from '../../src/main/desktop-storage-knowledge-operations'
|
||||
import type { DesktopStorageClient } from '../../src/main/desktop-storage-client'
|
||||
|
||||
/** Tests own their connection; production composition injects the storage client. */
|
||||
export class TestKnowledgeService extends KnowledgeService {
|
||||
private readonly owner: KnowledgeDatabase
|
||||
|
||||
constructor(options: Omit<KnowledgeServiceOptions, 'database'> & { databasePath: string }) {
|
||||
const owner = new KnowledgeDatabase(options.databasePath)
|
||||
owner.initialize()
|
||||
const call = async (domain: string, method: string, args: unknown[]) => {
|
||||
if (method === 'publishDocument') return publishStorageDocument(owner, ...args as Parameters<typeof publishStorageDocument> extends [unknown, ...infer A] ? A : never)
|
||||
if (method === 'replaceDocumentGraph') return replaceDocumentGraph(owner, ...args as Parameters<typeof replaceDocumentGraph> extends [unknown, ...infer A] ? A : never)
|
||||
const target = domain === 'external' ? owner.externalStore : owner
|
||||
return (target as unknown as Record<string, (...args: unknown[]) => unknown>)[method]!.apply(target, args)
|
||||
}
|
||||
const database = createKnowledgeStoragePort({ call: call as DesktopStorageClient['call'] })
|
||||
super({ ...options, database })
|
||||
this.owner = owner
|
||||
}
|
||||
|
||||
override async dispose(): Promise<void> {
|
||||
try { await super.dispose() } finally { this.owner.close() }
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user