feat(storage): move desktop SQLite ownership into a storage utility process

Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.

- Remove the Main readWithFallback path and the supervision worker's
  separate business write connection; manifests are scanned read-only and
  committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
  unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
  ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
  storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
  directories and reclaim confirmed stale ones; stop writing duplicate
  parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
  acceptance fixtures, and maintenance/architecture documentation.

Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
mesalogo
2026-10-06 15:40:18 +08:00
parent bc677a3718
commit d80d42b032
229 changed files with 13632 additions and 3800 deletions
@@ -241,6 +241,7 @@ export class EmbeddingIndexCoordinator {
private controller: AbortController | null = null
private completion: Promise<EmbeddingIndexJob> | null = null
private persistenceTail: Promise<void> = Promise.resolve()
private persistenceError?: unknown
constructor(
repository: EmbeddingIndexRepository,
@@ -307,6 +308,7 @@ export class EmbeddingIndexCoordinator {
options: EmbeddingRebuildOptions = {}
): EmbeddingIndexJob {
if (
this.controller ||
this.job?.status === 'queued' ||
this.job?.status === 'running'
) {
@@ -315,6 +317,7 @@ export class EmbeddingIndexCoordinator {
const providerName = validatedLabel(provider.provider, 'provider')
const model = validatedLabel(provider.model, 'model')
const controller = new AbortController()
this.persistenceError = undefined
const createdAt = this.now()
this.job = {
id: this.createId(),
@@ -347,6 +350,7 @@ export class EmbeddingIndexCoordinator {
this.controller = null
}
})
void this.completion.catch(() => undefined)
return this.job
}
@@ -502,7 +506,6 @@ export class EmbeddingIndexCoordinator {
})
}
signal.throwIfAborted()
this.updateJob({
status: 'completed',
completedAt: this.now(),
@@ -534,6 +537,7 @@ export class EmbeddingIndexCoordinator {
)
}
await this.persistenceTail
if (this.persistenceError) throw this.persistenceError
if (!this.job) {
throw new Error('Embedding index job state was lost')
}
@@ -556,8 +560,8 @@ export class EmbeddingIndexCoordinator {
this.persistenceTail = this.persistenceTail.then(async () => {
try {
await this.repository.saveStatus?.(status)
} catch {
// Persistence failure must not interrupt an active provider operation.
} catch (error) {
this.persistenceError ??= error
}
})
for (const listener of this.listeners) {
@@ -570,10 +574,11 @@ export class EmbeddingIndexCoordinator {
this.persistenceTail = this.persistenceTail.then(async () => {
try {
await this.repository.saveStatus?.(status)
} catch {
// Persistence failure must not interrupt initialization.
} catch (error) {
this.persistenceError ??= error
}
})
await this.persistenceTail
if (this.persistenceError) throw this.persistenceError
}
}