feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
@@ -33,6 +33,8 @@ export class DocumentResultStorage {
|
||||
return location
|
||||
}
|
||||
|
||||
location(id: string): { directory: string; original: string } { return this.require(id) }
|
||||
|
||||
isTemporaryResult(id: string): boolean { return this.results.has(id) }
|
||||
|
||||
async move(id: string, directory: string): Promise<void> {
|
||||
@@ -52,10 +54,12 @@ export class DocumentResultStorage {
|
||||
try {
|
||||
await mkdir(join(directory, 'images'), { recursive: true })
|
||||
if (original) await writeFile(originalPath, original)
|
||||
const images = await Promise.all((parsed.images ?? []).map(async ({ data, ...image }) => {
|
||||
const images: DocumentResult['images'] = []
|
||||
for (const { data, ...image } of parsed.images ?? []) {
|
||||
signal?.throwIfAborted()
|
||||
await writeFile(join(directory, 'images', image.id), data)
|
||||
return { ...image, size: data.byteLength }
|
||||
}))
|
||||
images.push({ ...image, size: data.byteLength })
|
||||
}
|
||||
const result = documentResultSchema.parse({
|
||||
id, fileName: name, sourceFormat: parsed.sourceFormat, content: parsed.content,
|
||||
sections: parsed.sections, images, pageCount: parsed.pageCount,
|
||||
@@ -64,7 +68,6 @@ export class DocumentResultStorage {
|
||||
completeness: parsedCompleteness(parsed),
|
||||
parsedAt: new Date().toISOString(), durationMs, settings, restructure: parsed.restructure
|
||||
})
|
||||
await writeFile(join(directory, 'parsed.md'), parsed.content)
|
||||
await writeFile(join(directory, 'manifest.json'), JSON.stringify(result))
|
||||
signal?.throwIfAborted()
|
||||
return result
|
||||
|
||||
Reference in New Issue
Block a user