feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
@@ -48,7 +48,7 @@ it('reserves before setup, rejects manual and resume overlap, and lets automatic
|
||||
expect(f.summarize).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('persists cancellation immediately but holds the slot until every in-flight batch settles', async () => {
|
||||
it('persists cancellation before model cleanup but holds the slot until every in-flight batch settles', async () => {
|
||||
const f = await fixture([['First'], ['Second']])
|
||||
const service = f.service()
|
||||
const entered = deferred(), finish = deferred()
|
||||
@@ -64,7 +64,7 @@ it('persists cancellation immediately but holds the slot until every in-flight b
|
||||
const runId = service.execution().runId!
|
||||
let cancelled = false
|
||||
const cancellation = service.cancel(runId).then(() => { cancelled = true })
|
||||
expect(f.db.listSupervisionActivity()[0]).toMatchObject({ status: 'cancelled', supervisionStatus: 'cancelled', resultId: null })
|
||||
await vi.waitFor(() => expect(f.db.listSupervisionActivity()[0]).toMatchObject({ status: 'cancelled', supervisionStatus: 'cancelled', resultId: null }))
|
||||
expect(signals.every(signal => signal.aborted)).toBe(true)
|
||||
expect(service.execution()).toEqual({ active: true, runId, stopping: 'cancelled' })
|
||||
await expect(service.run(request)).rejects.toThrow('SUPERVISION_REVIEW_BUSY')
|
||||
@@ -138,14 +138,14 @@ it('projects cancellation into heartbeat activity while runtime cleanup is still
|
||||
const result = await service.run({ ...request, trigger: 'heartbeat' }, run.id)
|
||||
return { status: result.status ?? 'completed', runId: result.runId }
|
||||
} })
|
||||
const config = heartbeat.create({ name: 'Review', scope: request.scope, timezone: 'UTC',
|
||||
const config = await heartbeat.create({ name: 'Review', scope: request.scope, timezone: 'UTC',
|
||||
recurrence: { type: 'daily', localTime: '09:00' }, enabled: true, lookbackHours: 24, retentionDays: 30 })
|
||||
const pending = heartbeat.runNow({ id: config.id, idempotencyKey: randomUUID() })
|
||||
await entered.promise
|
||||
const runId = service.execution().runId!
|
||||
const cancellation = service.cancel(runId)
|
||||
expect(f.db.listSupervisionActivity()).toEqual([expect.objectContaining({ kind: 'heartbeat', status: 'cancelled',
|
||||
heartbeatStatus: 'completed', supervisionStatus: 'cancelled', completedAt: expect.any(String), reviewProgress: expect.objectContaining({ runId }) })])
|
||||
await vi.waitFor(() => expect(f.db.listSupervisionActivity()).toEqual([expect.objectContaining({ kind: 'heartbeat', status: 'cancelled',
|
||||
heartbeatStatus: 'completed', supervisionStatus: 'cancelled', completedAt: expect.any(String), reviewProgress: expect.objectContaining({ runId }) })]))
|
||||
finish.resolve()
|
||||
await cancellation
|
||||
await pending
|
||||
|
||||
Reference in New Issue
Block a user