feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
@@ -4,6 +4,7 @@ import { ModelAgentRuntime, noModelTools } from '../agent/model-runtime'
|
||||
import { AssistantDatabase } from './assistant-database'
|
||||
import { SupervisionModelPool } from './supervision-model-pool'
|
||||
import { createProductionSuggestionPhraser } from './supervision-production'
|
||||
import { asyncSupervisionStorage } from '../../../tests/support/async-supervision-storage'
|
||||
|
||||
const cleanups: Array<() => void> = []
|
||||
afterEach(() => {
|
||||
@@ -20,7 +21,7 @@ function fixture(run: AgentRuntime['run'], timeoutSeconds = 30) {
|
||||
const dispose = vi.fn(async () => {})
|
||||
const runtime = { run: vi.fn(run), releaseConversation: release, dispose } as unknown as AgentRuntime
|
||||
const statuses = vi.spyOn(db, 'updateTaskStatus')
|
||||
const phrase = createProductionSuggestionPhraser(db, async () => ({ supervisorModelConcurrency: 1,
|
||||
const phrase = createProductionSuggestionPhraser(asyncSupervisionStorage(db).supervision, async () => ({ supervisorModelConcurrency: 1,
|
||||
supervisorOrganizeTimeoutSeconds: timeoutSeconds }), async () => runtime, pool)
|
||||
cleanups.push(() => { pool.dispose(); db.close() })
|
||||
return { db, pool, runtime, release, dispose, statuses,
|
||||
|
||||
Reference in New Issue
Block a user