feat(storage): move desktop SQLite ownership into a storage utility process
Main no longer opens desktop business SQLite. A single utility-process
storage owner holds the Assistant, Knowledge, attachment, document-result,
remote-binding and native model-ledger databases and runs whole domain
transactions; Main and Runtime callers use explicit async domain operations.
- Remove the Main readWithFallback path and the supervision worker's
separate business write connection; manifests are scanned read-only and
committed by the sole writer.
- Remote events are ACKed only after commit; process loss reports
unconfirmed writes instead of replaying them.
- Use native utilityProcess messaging with one in-flight bound (32) and
ordered waiting instead of capacity rejection and retries.
- Start the storage process before the window so startup overlaps.
- Keep short tool output in memory and store full output once in owned
storage; paging, branching, restart and deletion reuse that copy.
- Put required runtime launch files under goodbuddy-prefixed owned temp
directories and reclaim confirmed stale ones; stop writing duplicate
parsed.md.
- Add lint guards for SQLite ownership and architecture, concurrency
acceptance fixtures, and maintenance/architecture documentation.
Validation: typecheck and lint pass. Alternating baseline (edf019aa) vs
candidate runs show no regression on single-session, C01, C02, C04 and a
5-minute C06; Main p99 drops from ~21 ms to ~16.7 ms under concurrency.
Fresh portable copy (1.75M events) upgrade content unchanged; real-model
output paging passes with 4 external requests. Full npm test runs had
1-9 different timing-sensitive failures per run that pass when rerun.
Not covered: C03 review publication, C07 source body, app-level C05.
This commit is contained in:
@@ -44,12 +44,12 @@ type RemoteDelegationOptions = {
|
||||
transport?: RemoteTransport
|
||||
intervalMs?: number
|
||||
outbox?: {
|
||||
listPending: () => Array<{ taskId: string; result: RemoteResult }>
|
||||
listPending: () => Array<{ taskId: string; result: RemoteResult }> | Promise<Array<{ taskId: string; result: RemoteResult }>>
|
||||
getStatus: (
|
||||
taskId: string
|
||||
) => 'pending' | 'delivered' | undefined
|
||||
save: (taskId: string, result: RemoteResult) => void
|
||||
markDelivered: (taskId: string) => void
|
||||
) => 'pending' | 'delivered' | undefined | Promise<'pending' | 'delivered' | undefined>
|
||||
save: (taskId: string, result: RemoteResult) => void | Promise<void>
|
||||
markDelivered: (taskId: string) => void | Promise<void>
|
||||
}
|
||||
}
|
||||
|
||||
@@ -207,7 +207,7 @@ export class RemoteDelegationService {
|
||||
this.activeRequest = controller
|
||||
try {
|
||||
const address = await this.resolveAddress()
|
||||
const durablePending = this.options.outbox?.listPending()[0]
|
||||
const durablePending = (await this.options.outbox?.listPending())?.[0]
|
||||
const memoryPending = this.pendingResults.entries().next().value
|
||||
const pending = durablePending
|
||||
? ([durablePending.taskId, durablePending.result] as const)
|
||||
@@ -219,7 +219,7 @@ export class RemoteDelegationService {
|
||||
address,
|
||||
controller.signal
|
||||
)
|
||||
this.markDelivered(pending[0])
|
||||
await this.markDelivered(pending[0])
|
||||
}
|
||||
const nextUrl = endpointUrl(this.endpoint, '/goodbuddy/tasks/next')
|
||||
const response = await this.transport(
|
||||
@@ -238,14 +238,13 @@ export class RemoteDelegationService {
|
||||
const task = remoteTaskSchema.parse(JSON.parse(response.body))
|
||||
if (
|
||||
this.deliveredIds.has(task.id) ||
|
||||
this.options.outbox?.getStatus(task.id) === 'delivered'
|
||||
(await this.options.outbox?.getStatus(task.id)) === 'delivered'
|
||||
) {
|
||||
return
|
||||
}
|
||||
const existingResult =
|
||||
this.options.outbox
|
||||
?.listPending()
|
||||
.find((item) => item.taskId === task.id)?.result ??
|
||||
(await this.options.outbox?.listPending())
|
||||
?.find((item) => item.taskId === task.id)?.result ??
|
||||
this.pendingResults.get(task.id)
|
||||
let result: RemoteResult
|
||||
if (existingResult) {
|
||||
@@ -260,13 +259,13 @@ export class RemoteDelegationService {
|
||||
}
|
||||
}
|
||||
if (this.options.outbox) {
|
||||
this.options.outbox.save(task.id, result)
|
||||
await this.options.outbox.save(task.id, result)
|
||||
} else {
|
||||
this.pendingResults.set(task.id, result)
|
||||
}
|
||||
}
|
||||
await this.deliverResult(task.id, result, address, controller.signal)
|
||||
this.markDelivered(task.id)
|
||||
await this.markDelivered(task.id)
|
||||
} finally {
|
||||
if (this.activeRequest === controller) {
|
||||
this.activeRequest = undefined
|
||||
@@ -301,9 +300,9 @@ export class RemoteDelegationService {
|
||||
}
|
||||
}
|
||||
|
||||
private markDelivered(taskId: string): void {
|
||||
private async markDelivered(taskId: string): Promise<void> {
|
||||
await this.options.outbox?.markDelivered(taskId)
|
||||
this.pendingResults.delete(taskId)
|
||||
this.options.outbox?.markDelivered(taskId)
|
||||
this.deliveredIds.add(taskId)
|
||||
if (this.deliveredIds.size > 1_000) {
|
||||
const oldest = this.deliveredIds.values().next().value
|
||||
|
||||
Reference in New Issue
Block a user