fix: keep Chinese downloads on OSS loading state
Cross-platform packages / Validate source (push) Canceled after 0s
Deploy website to GitHub Pages / Deploy static website (push) Canceled after 0s
Cross-platform packages / Authorize desktop packaging (push) Canceled after 0s
Cross-platform packages / linux arm64 (push) Canceled after 0s
Cross-platform packages / macos arm64 (push) Canceled after 0s
Cross-platform packages / windows arm64 (push) Canceled after 0s
Cross-platform packages / linux x64 (push) Canceled after 0s
Cross-platform packages / macos x64 (push) Canceled after 0s
Cross-platform packages / windows x64 (push) Canceled after 0s
Cross-platform packages / Publish GitHub and OSS release (push) Canceled after 0s
Cross-platform packages / Validate source (push) Canceled after 0s
Deploy website to GitHub Pages / Deploy static website (push) Canceled after 0s
Cross-platform packages / Authorize desktop packaging (push) Canceled after 0s
Cross-platform packages / linux arm64 (push) Canceled after 0s
Cross-platform packages / macos arm64 (push) Canceled after 0s
Cross-platform packages / windows arm64 (push) Canceled after 0s
Cross-platform packages / linux x64 (push) Canceled after 0s
Cross-platform packages / macos x64 (push) Canceled after 0s
Cross-platform packages / windows x64 (push) Canceled after 0s
Cross-platform packages / Publish GitHub and OSS release (push) Canceled after 0s
The Chinese download cards briefly exposed the GitHub fallback before OSS index validation completed. They now stay disabled while loading and only show GitHub if the OSS request or validation fails; English downloads remain unchanged. Release note: 中文官网下载入口加载 OSS 索引期间不再短暂跳转 GitHub,仅在索引失败时回退。
This commit is contained in:
@@ -282,6 +282,36 @@ test("enables only a validated LoongArch preview download", async () => {
|
||||
dom.window.close();
|
||||
});
|
||||
|
||||
test("keeps Chinese downloads disabled while the OSS indexes are loading", async () => {
|
||||
const { dom, window } = renderLoongArchPreview({
|
||||
goodBuddyVersion: "0.11.5",
|
||||
artifact: {
|
||||
size: 186_853_872,
|
||||
sha256: "a".repeat(64),
|
||||
url: "https://goodbuddy.oss-cn-beijing.aliyuncs.com/releases/loongarch-preview/v0.11.5/GoodBuddy-0.11.5-linux-loong64-preview.deb",
|
||||
},
|
||||
});
|
||||
const arch = window.document.querySelector("[data-download-arch]");
|
||||
const link = window.document.querySelector("[data-release-link]");
|
||||
const meta = window.document.querySelector("[data-download-meta]");
|
||||
|
||||
assert.equal(link.hasAttribute("href"), false);
|
||||
assert.equal(link.getAttribute("aria-disabled"), "true");
|
||||
assert.equal(link.tabIndex, -1);
|
||||
assert.equal(link.classList.contains("is-disabled"), true);
|
||||
assert.equal(link.textContent, "正在获取 Linux 下载信息…(在新窗口打开)");
|
||||
assert.equal(meta.textContent, "正在从 OSS 获取最新版本。");
|
||||
|
||||
arch.value = "loong64";
|
||||
arch.dispatchEvent(new window.Event("change"));
|
||||
assert.equal(link.hasAttribute("href"), false);
|
||||
assert.equal(link.getAttribute("aria-disabled"), "true");
|
||||
assert.equal(link.textContent, "正在获取龙芯预览版下载信息…(在新窗口打开)");
|
||||
assert.equal(meta.textContent, "正在从 OSS 获取最新版本。");
|
||||
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
||||
dom.window.close();
|
||||
});
|
||||
|
||||
test("keeps the LoongArch preview disabled when its index is unavailable", async () => {
|
||||
const { dom, window } = renderLoongArchPreview(null);
|
||||
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
||||
|
||||
@@ -311,11 +311,12 @@ const releaseLinks = [
|
||||
report(releaseLinks.length >= 3, "缺少三个桌面系统的官方下载入口");
|
||||
for (const link of releaseLinks) {
|
||||
report(
|
||||
/href="https:\/\/github\.com\/mesalogo\/goodbuddy\/releases\/latest"/.test(link),
|
||||
`下载入口必须指向官方最新 Release:${link}`,
|
||||
!/\shref=/.test(link),
|
||||
`中文下载入口加载期间不得预先指向 GitHub:${link}`,
|
||||
);
|
||||
report(/target="_blank"/.test(link), `下载入口必须在新窗口打开:${link}`);
|
||||
report(/rel="[^"]*noreferrer[^"]*"/.test(link), `下载入口缺少 noreferrer:${link}`);
|
||||
report(/aria-disabled="true"/.test(link), `中文下载入口加载期间必须禁用:${link}`);
|
||||
report(/tabindex="-1"/.test(link), `禁用的中文下载入口不得进入 Tab 顺序:${link}`);
|
||||
report(/\bis-disabled\b/.test(link), `中文下载入口缺少禁用样式:${link}`);
|
||||
}
|
||||
report(
|
||||
(html.match(/data-download-card="(?:windows|macos|linux)"/g) ?? []).length === 3,
|
||||
|
||||
Reference in New Issue
Block a user