perf(activity): page, summarize and reconcile activity history in Main by index
Schema 57 rebuilds activity_history_records with order_seq (newer = larger;
a move to the front assigns a new maximum) and stored generated columns
(record_id, occurrence, status, status_group, kind, request_id,
conversation_id, project_id, created_at) with indexes. The order is migrated
from record_order_json exactly; legacy duplicates keep their occurrence and
only the first is shown. record_order_json is no longer written.
ActivityHistoryRepository owns the SQL: page({before, limit <= 500, filter,
projectId, conversationId}) newest first by index, summary() with the counts
and conversation titles/status the Activity page derived from the full list,
reconcile() joined with tasks with a renderer-localized detail line, update()
applied directly in SQL without reading the history, replace() for the
legacy migration, clear(). New activity-history:page/summary/reconcile IPC
with zod validation; page and summary run on the readonly worker.
perf:main measures 24,000 records: startup load 106 ms on Main (14 MB) ->
first page + summary 13.5 ms on the worker (0.6 ms loop block, 114 KB).
This commit is contained in:
@@ -8,7 +8,7 @@ import { z } from 'zod'
|
||||
import { activityHistorySnapshotSchema, type ActivityHistoryChange, type ActivityRecord } from '../../shared/assistant-contracts'
|
||||
import { applyActivityChanges } from '../../shared/activity-history-reference'
|
||||
import { AssistantDatabase } from './assistant-database'
|
||||
import { parseActivityHistorySnapshot, planActivityHistoryReplace, planActivityHistoryUpdate } from './activity-history-plan'
|
||||
import { parseActivityHistorySnapshot, planActivityHistoryReplace } from './activity-history-plan'
|
||||
|
||||
const directories: string[] = []
|
||||
const opened: AssistantDatabase[] = []
|
||||
@@ -29,8 +29,9 @@ function open(): { database: AssistantDatabase; raw: DatabaseSync; directory: st
|
||||
/** The complete persisted state, independent of the read API. */
|
||||
function storedState(raw: DatabaseSync): unknown {
|
||||
return {
|
||||
header: raw.prepare('SELECT record_order_json, legacy_history_may_be_incomplete FROM activity_history').all(),
|
||||
rows: raw.prepare('SELECT record_key, record_json FROM activity_history_records ORDER BY record_key').all()
|
||||
header: raw.prepare('SELECT legacy_history_may_be_incomplete FROM activity_history').all(),
|
||||
// Sequence values may differ; their order may not.
|
||||
rows: raw.prepare('SELECT record_key, record_json FROM activity_history_records ORDER BY order_seq DESC, record_key').all()
|
||||
}
|
||||
}
|
||||
|
||||
@@ -112,8 +113,8 @@ describe('activity history incremental updates', () => {
|
||||
database.updateActivityHistory({ changes: [{ type: 'upsert', position: 'front', record: { ...records[1_500]!, status: 'completed' } }] })
|
||||
const calls = stringify.mock.calls.filter(([value]) => !Array.isArray(value)).length
|
||||
stringify.mockRestore()
|
||||
// One record row plus the order row.
|
||||
expect(changes() - start).toBe(2)
|
||||
// One record row; no order list is rewritten.
|
||||
expect(changes() - start).toBe(1)
|
||||
expect(calls).toBeLessThan(10)
|
||||
})
|
||||
})
|
||||
@@ -183,11 +184,11 @@ describe('activity history replace', () => {
|
||||
const empty = { entries: new Map() }
|
||||
const first = planActivityHistoryReplace(parseActivityHistorySnapshot({ records, legacyHistoryMayBeIncomplete: false }).items, false, empty)
|
||||
const reparsed = parseActivityHistorySnapshot(structuredClone({ records, legacyHistoryMayBeIncomplete: false }), first.next)
|
||||
expect(reparsed.items.every((item, index) => item.record === first.next.entries.get([...first.next.order][index]!)!.record)).toBe(true)
|
||||
const keys = ['["a",0]', '["b",0]', '["a",1]']
|
||||
expect(reparsed.items.every((item, index) => item.record === first.next.entries.get(keys[index]!)!.record)).toBe(true)
|
||||
const second = planActivityHistoryReplace(reparsed.items, false, first.next)
|
||||
expect(second.upserts).toEqual([])
|
||||
expect(second.removes).toEqual([])
|
||||
expect(second.headerChanged).toBe(false)
|
||||
expect(() => planActivityHistoryUpdate({ changes: [] }, { entries: new Map() })).toThrow('unreadable')
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user