feat: connect conversations with Magic Notes
Let users retain useful assistant replies or complete conversations without leaving their chat workflow. Preview and edit captured text, choose an existing note or atomically create a note with its first entry, and return to the source conversation or message from saved records. Add an application-scoped Notes workbar tab with title/body search and quick text appends. Preserve drafts across conversation switches and guard closing, replacement and disabling. Schema 48 stores optional source metadata without rewriting file-backed bodies; source deletion retains the saved note. Older clients cannot reopen an upgraded database without a pre-upgrade backup. Release note: 可将助手回答或完整会话预览、编辑后加入魔法笔记，并从笔记返回原会话或消息。右侧快速笔记支持搜索和追加文字，切换会话保留草稿；采集本身不调用模型，保存后自动评论仍遵循已有设置。 Validation: isolated HEAD-based candidate passed 22 files / 930 focused tests, plus 20 gateway tests after including its create-result fixture adjustment. Real Electron App/preload/IPC/SQLite acceptance passed for all 502 historical messages, exact-entry/source navigation, native keyboard input in a 214px panel, reopen and source-deletion retention, with zero capture model calls. Repository lint and web TypeScript passed. Cached whitespace and secret-pattern checks passed; native-client changes and unrelated IPC extraction are excluded. Validation limits: the isolated source tree reuses installed node_modules, where a parallel task upgraded DSH from the committed 0.1.2-rc.1 to 0.1.7-rc.2. Full typecheck reports 14 DSH errors in three unchanged files; the full-suite attempt with --bail=1 also fails in deepseek-harness-host.test.ts. These are not all-green repository or release-package results. Earlier execution-time full suite failures and fixture repairs remain recorded in the feature progress doc.
This commit is contained in:
mesalogo
@@ -889,10 +889,10 @@ describe('KnowledgeMcpGateway', () => {
|
||||
gateway.getMagicNote(readToken, { noteId: created.id })
|
||||
).toThrow('笔记不存在')
|
||||
|
||||
const canvas = database.createMagicNote({ title: 'Canvas', content: {
|
||||
const canvas = database.getMagicNote(database.createMagicNote({ title: 'Canvas', content: {
|
||||
version: 2, kind: 'paged-canvas', assets: [],
|
||||
pages: [{ id: 'page', width: 794, height: 1123, background: { type: 'template', template: 'blank' }, objects: [{ type: 'IText', text: 'Canvas text' }] }]
|
||||
} })
|
||||
} }).id)
|
||||
const canvasEntry = gateway.getMagicNote(readToken, { noteId: canvas.id }).entries[0]!
|
||||
expect(canvasEntry).toMatchObject({ content: 'Canvas text', contentKind: 'paged-canvas', contentVersion: 2, plainTextEditable: false })
|
||||
expect(() => gateway.updateMagicNoteEntry(writeToken, { entryId: canvasEntry.id, expectedRevision: canvasEntry.revision, content: 'overwrite' })).toThrow('画布记录不能')
|
||||
|
||||
@@ -31,6 +31,7 @@ it('migrates activity history and writes only changed records during streaming',
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version=43`)
|
||||
const legacySave = raw.prepare('UPDATE activity_history SET records_json = ?, legacy_history_may_be_incomplete = 1')
|
||||
legacySave.run(JSON.stringify(records))
|
||||
|
||||
@@ -178,6 +178,7 @@ it('migrates schema 35 conversations to unpinned while retaining existing data a
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 35;`)
|
||||
legacy.close()
|
||||
try {
|
||||
@@ -332,6 +333,7 @@ it('preserves existing supervision data when upgrading schema 41 and reopening',
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 41;`)
|
||||
legacy.close()
|
||||
try {
|
||||
@@ -1098,6 +1100,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 3;
|
||||
`)
|
||||
oldDatabase.close()
|
||||
@@ -1264,6 +1267,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 26;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1383,6 +1387,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 30;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1464,6 +1469,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 30;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1564,6 +1570,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 24;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1614,6 +1621,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 24;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1665,6 +1673,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 24;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1712,6 +1721,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 24;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1748,6 +1758,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 24;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -1781,6 +1792,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 5;
|
||||
`)
|
||||
versionFive.close()
|
||||
@@ -1911,6 +1923,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 21;
|
||||
COMMIT;
|
||||
`)
|
||||
@@ -2010,6 +2023,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 9;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -2071,6 +2085,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 16`)
|
||||
legacy.close()
|
||||
|
||||
@@ -3026,6 +3041,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 23`)
|
||||
legacy.close()
|
||||
|
||||
@@ -3193,6 +3209,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 18;
|
||||
`)
|
||||
legacy.close()
|
||||
@@ -3709,6 +3726,7 @@ describe('AssistantDatabase', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 31;
|
||||
`)
|
||||
legacy.close()
|
||||
|
||||
@@ -86,6 +86,9 @@ import {
|
||||
} from '../../shared/runtime-selection-contracts'
|
||||
import {
|
||||
MAGIC_NOTE_MAX_NOTE_EMBED_BYTES,
|
||||
magicNoteSourceSchema,
|
||||
type MagicNoteSource,
|
||||
type MagicNoteCreateResult,
|
||||
type MagicNoteComment,
|
||||
type MagicNoteDetail,
|
||||
type MagicNoteEntryCreateResult,
|
||||
@@ -119,7 +122,7 @@ import {
|
||||
SUBAGENT_PROGRESS_STORAGE_SCHEMA_VERSION
|
||||
} from './subagent-progress-storage'
|
||||
|
||||
export const ASSISTANT_DATABASE_SCHEMA_VERSION = 47
|
||||
export const ASSISTANT_DATABASE_SCHEMA_VERSION = 48
|
||||
|
||||
export type RemoteTaskEventInput = {
|
||||
taskId: string
|
||||
@@ -256,6 +259,7 @@ type MagicNoteEntryRow = {
|
||||
id: string
|
||||
note_id: string
|
||||
content_json: string
|
||||
source_json: string | null
|
||||
plain_text: string
|
||||
comments_json: string
|
||||
analyzed_at: string | null
|
||||
@@ -666,6 +670,7 @@ function toMagicNoteEntry(row: MagicNoteEntryRow, content: MagicNoteContent): Ma
|
||||
id: row.id,
|
||||
noteId: row.note_id,
|
||||
content,
|
||||
...(row.source_json ? { source: magicNoteSourceSchema.parse(JSON.parse(row.source_json)) } : {}),
|
||||
plainText: row.plain_text,
|
||||
comments: JSON.parse(row.comments_json) as MagicNoteComment[],
|
||||
analyzedAt: row.analyzed_at ?? undefined,
|
||||
@@ -3920,8 +3925,12 @@ export class AssistantDatabase {
|
||||
createMagicNote(input: {
|
||||
title: string
|
||||
content?: MagicNoteContent
|
||||
}): MagicNoteDetail {
|
||||
source?: MagicNoteSource
|
||||
}): MagicNoteCreateResult {
|
||||
const id = randomUUID()
|
||||
const entryId = input.content ? randomUUID() : undefined
|
||||
const source = input.source ? magicNoteSourceSchema.parse(input.source) : undefined
|
||||
if (source && !input.content) throw new Error('Source requires initial content')
|
||||
const now = new Date().toISOString()
|
||||
const database = this.requireDatabase()
|
||||
if (input.content) {
|
||||
@@ -3945,16 +3954,15 @@ export class AssistantDatabase {
|
||||
VALUES (?, ?, ?, 0, ?, ?, ?)`
|
||||
)
|
||||
.run(id, null, input.title, input.content ? 1 : 0, now, now)
|
||||
if (input.content) {
|
||||
const entryId = randomUUID()
|
||||
if (input.content && entryId) {
|
||||
const pointer = this.writeMagicNoteBody(id, entryId, input.content, 0, now)
|
||||
database
|
||||
.prepare(
|
||||
`INSERT INTO magic_note_entries
|
||||
(id, note_id, content_json, plain_text, comments_json,
|
||||
actions_json, analyzed_at, revision, created_at, updated_at,
|
||||
image_bytes)
|
||||
VALUES (?, ?, ?, ?, '[]', '[]', NULL, 0, ?, ?, ?)`
|
||||
image_bytes, source_json)
|
||||
VALUES (?, ?, ?, ?, '[]', '[]', NULL, 0, ?, ?, ?, ?)`
|
||||
)
|
||||
.run(
|
||||
entryId,
|
||||
@@ -3963,7 +3971,8 @@ export class AssistantDatabase {
|
||||
magicNotePlainText(input.content),
|
||||
now,
|
||||
now,
|
||||
embeddedBytes
|
||||
embeddedBytes,
|
||||
source ? JSON.stringify(source) : null
|
||||
)
|
||||
this.syncMagicNoteTodos(
|
||||
database,
|
||||
@@ -3984,7 +3993,7 @@ export class AssistantDatabase {
|
||||
if (input.content) {
|
||||
this.notifyMagicTodosChanged()
|
||||
}
|
||||
return detail
|
||||
return { ...detail, ...(entryId ? { createdEntryId: entryId } : {}) }
|
||||
}
|
||||
|
||||
updateMagicNote(input: {
|
||||
@@ -4034,7 +4043,9 @@ export class AssistantDatabase {
|
||||
noteId: string
|
||||
content: MagicNoteContent
|
||||
plainText: string
|
||||
source?: MagicNoteSource
|
||||
}): MagicNoteEntryCreateResult {
|
||||
const source = input.source ? magicNoteSourceSchema.parse(input.source) : undefined
|
||||
const database = this.requireDatabase()
|
||||
const entryId = randomUUID()
|
||||
const content = validateMagicNoteContent(input.content)
|
||||
@@ -4059,8 +4070,8 @@ export class AssistantDatabase {
|
||||
`INSERT INTO magic_note_entries
|
||||
(id, note_id, content_json, plain_text, comments_json,
|
||||
actions_json, analyzed_at, revision, created_at, updated_at,
|
||||
image_bytes)
|
||||
VALUES (?, ?, ?, ?, '[]', '[]', NULL, 0, ?, ?, ?)`
|
||||
image_bytes, source_json)
|
||||
VALUES (?, ?, ?, ?, '[]', '[]', NULL, 0, ?, ?, ?, ?)`
|
||||
)
|
||||
.run(
|
||||
entryId,
|
||||
@@ -4069,7 +4080,8 @@ export class AssistantDatabase {
|
||||
input.plainText,
|
||||
now,
|
||||
now,
|
||||
magicNoteEmbeddedBytes(input.content)
|
||||
magicNoteEmbeddedBytes(input.content),
|
||||
source ? JSON.stringify(source) : null
|
||||
)
|
||||
this.syncMagicNoteTodos(
|
||||
database,
|
||||
@@ -4287,6 +4299,23 @@ export class AssistantDatabase {
|
||||
return { incompleteCount: row.incomplete_count }
|
||||
}
|
||||
|
||||
searchMagicNoteSummaries(query: string, limit = 200): MagicNoteSummary[] {
|
||||
const pattern = `%${query.replace(/[\\%_]/gu, '\\$&')}%`
|
||||
const rows = this.requireDatabase().prepare(
|
||||
`SELECT n.*,
|
||||
(SELECT COUNT(*) FROM magic_note_entries e WHERE e.note_id = n.id) AS entry_count,
|
||||
(SELECT plain_text FROM magic_note_entries e WHERE e.note_id = n.id
|
||||
ORDER BY e.created_at DESC, e.rowid DESC LIMIT 1) AS latest_plain_text
|
||||
FROM magic_notes n
|
||||
WHERE n.title LIKE ? ESCAPE '\\'
|
||||
OR EXISTS (SELECT 1 FROM magic_note_entries e
|
||||
WHERE e.note_id = n.id AND e.plain_text LIKE ? ESCAPE '\\')
|
||||
ORDER BY n.pinned DESC, n.updated_at DESC, n.rowid DESC
|
||||
LIMIT ?`
|
||||
).all(pattern, pattern, limit) as MagicNoteRow[]
|
||||
return rows.map(toMagicNoteSummary)
|
||||
}
|
||||
|
||||
searchMagicNotes(query: string, limit: number): MagicNoteSearchResult[] {
|
||||
const pattern = `%${query.replace(/[\\%_]/gu, '\\$&')}%`
|
||||
return (
|
||||
@@ -11426,6 +11455,13 @@ export class AssistantDatabase {
|
||||
database.exec('PRAGMA user_version = 47; COMMIT;')
|
||||
} catch (error) { database.exec('ROLLBACK'); throw error }
|
||||
}
|
||||
if (version.user_version < 48) {
|
||||
database.exec('BEGIN IMMEDIATE')
|
||||
try {
|
||||
database.exec('ALTER TABLE magic_note_entries ADD COLUMN source_json TEXT;')
|
||||
database.exec('PRAGMA user_version = 48; COMMIT;')
|
||||
} catch (error) { database.exec('ROLLBACK'); throw error }
|
||||
}
|
||||
}
|
||||
|
||||
supervisionReviewStore(): SupervisionReviewStore {
|
||||
|
||||
@@ -55,12 +55,12 @@ function subagent(requestId: string): SubagentEvent {
|
||||
}
|
||||
|
||||
describe('subagent progress storage', () => {
|
||||
it.each([45, 46])('upgrades schema %i without reconverting history or vacuuming ordinary free pages', async (sourceVersion) => {
|
||||
it.each([45, 46, 47])('upgrades schema %i without reconverting history or vacuuming ordinary free pages', async (sourceVersion) => {
|
||||
const { path, database, taskId } = await fixture()
|
||||
const event = subagent(randomUUID())
|
||||
event.progress = [{ id: randomUUID(), type: 'text', content: 'Keep current-format progress' }]
|
||||
database.appendTaskEvent(taskId, 'subagent', event)
|
||||
const note = database.createMagicNote({ title: 'Already migrated', content: { version: 1, ops: [{ insert: 'Keep note\n' }] } })
|
||||
const note = database.getMagicNote(database.createMagicNote({ title: 'Already migrated', content: { version: 1, ops: [{ insert: 'Keep note\n' }] } }).id)
|
||||
const header = { id: randomUUID(), title: 'Keep chat', updatedAt: 1000 }
|
||||
const message = { id: randomUUID(), role: 'assistant' as const, state: 'complete' as const,
|
||||
content: 'Normal chat update'.repeat(100_000), createdAt: 1000 }
|
||||
@@ -70,14 +70,15 @@ describe('subagent progress storage', () => {
|
||||
database.close()
|
||||
const sql = new DatabaseSync(path)
|
||||
try {
|
||||
sql.exec(`DROP VIEW supervision_review_current;
|
||||
if (sourceVersion < 47) sql.exec(`DROP VIEW supervision_review_current;
|
||||
DROP TABLE supervision_review_navigation; DROP TABLE supervision_review_batches;
|
||||
DROP TABLE supervision_review_sources; DROP TABLE supervision_review_runs;`)
|
||||
if (sourceVersion === 45) sql.exec(`
|
||||
DROP TRIGGER messages_review_insert; DROP TRIGGER messages_review_update;
|
||||
DROP TRIGGER messages_review_delete; DROP TRIGGER tasks_review_delete;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;`)
|
||||
sql.exec(`PRAGMA user_version = ${sourceVersion}; PRAGMA wal_checkpoint(TRUNCATE)`)
|
||||
sql.exec(`ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = ${sourceVersion}; PRAGMA wal_checkpoint(TRUNCATE)`)
|
||||
expect(sql.prepare('PRAGMA freelist_count').get()!.freelist_count).toBeGreaterThan(0)
|
||||
const events = sql.prepare('SELECT * FROM task_events WHERE task_id = ? ORDER BY id').all(taskId)
|
||||
expect(events.length).toBeGreaterThan(0)
|
||||
@@ -143,7 +144,7 @@ describe('subagent progress storage', () => {
|
||||
|
||||
it('does not re-show migration after a note is already migrated and later chats free pages', async () => {
|
||||
const { path, database } = await fixture()
|
||||
const note = database.createMagicNote({ title: 'Legacy note', content: { version: 1, ops: [{ insert: 'note body\n' }] } })
|
||||
const note = database.getMagicNote(database.createMagicNote({ title: 'Legacy note', content: { version: 1, ops: [{ insert: 'note body\n' }] } }).id)
|
||||
database.close()
|
||||
const legacy = new DatabaseSync(path)
|
||||
try {
|
||||
@@ -158,6 +159,7 @@ describe('subagent progress storage', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 37`)
|
||||
} finally { legacy.close() }
|
||||
expect(hasPendingAssistantStorageUpgrade(path)).toBe(true)
|
||||
@@ -479,6 +481,7 @@ describe('subagent progress storage', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = ${sourceVersion}; BEGIN`)
|
||||
const insert = legacy.prepare(
|
||||
`INSERT INTO task_events(
|
||||
|
||||
@@ -86,6 +86,7 @@ describe('AssistantDatabase heartbeat persistence', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 2`)
|
||||
raw.close()
|
||||
|
||||
@@ -148,6 +149,7 @@ describe('AssistantDatabase heartbeat persistence', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 20`)
|
||||
raw.close()
|
||||
|
||||
|
||||
@@ -193,7 +193,7 @@ it('preserves schema-45 plans, reports, IDs and foreign keys while extending sta
|
||||
sql.exec(`INSERT INTO ${table}_old SELECT * FROM ${table}; DROP TABLE ${table}; ALTER TABLE ${table}_old RENAME TO ${table};`)
|
||||
for (const index of indexes) sql.exec(String(index.sql))
|
||||
}
|
||||
sql.exec('PRAGMA user_version = 45; COMMIT; PRAGMA foreign_keys = ON;')
|
||||
sql.exec('ALTER TABLE magic_note_entries DROP COLUMN source_json; PRAGMA user_version = 45; COMMIT; PRAGMA foreign_keys = ON;')
|
||||
db.initialize(directory)
|
||||
expect(db.getHeartbeatConfig(config.id)).toEqual(savedConfig)
|
||||
expect(db.listHeartbeatEntries(config.id)).toEqual(savedEntries)
|
||||
|
||||
@@ -134,6 +134,7 @@ it('upgrades schema 44 without inventing historical links and preserves runs on
|
||||
DROP TABLE supervision_review_navigation; DROP TABLE supervision_review_batches;
|
||||
DROP TABLE supervision_review_sources; DROP TABLE supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 44;`)
|
||||
legacy.close()
|
||||
db.initialize(process.cwd())
|
||||
|
||||
@@ -46,6 +46,7 @@ it('supervision preserves result history and protected identities within scope t
|
||||
DROP TABLE supervision_review_navigation; DROP TABLE supervision_review_batches;
|
||||
DROP TABLE supervision_review_sources; DROP TABLE supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 42;`)
|
||||
legacy.close()
|
||||
db.initialize(process.cwd())
|
||||
|
||||
+32
-3
@@ -198,6 +198,8 @@ import {
|
||||
import {
|
||||
magicNoteAnalyzeSchema,
|
||||
magicNoteCreateSchema,
|
||||
magicNoteSearchSchema,
|
||||
type MagicNoteSource,
|
||||
magicNoteDeleteSchema,
|
||||
magicNoteDraftAnalyzeSchema,
|
||||
magicNoteEntryCreateSchema,
|
||||
@@ -8430,6 +8432,33 @@ export function registerIpcHandlers(
|
||||
contextManager.remove(requestIdSchema.parse(input))
|
||||
})
|
||||
|
||||
const resolveMagicNoteSource = (source?: MagicNoteSource): MagicNoteSource | undefined => {
|
||||
if (!source) return undefined
|
||||
const conversation = assistantDatabase.getConversation(source.conversationId)
|
||||
const messages = new Map(conversation.messages.map((message) => [message.id, message]))
|
||||
for (const id of source.messageIds) {
|
||||
const message = messages.get(id)
|
||||
if (!message || (source.kind === 'message' && message.role !== 'assistant')) {
|
||||
throw new Error('Invalid conversation source message')
|
||||
}
|
||||
}
|
||||
const project = conversation.projectId ? assistantDatabase.getProject(conversation.projectId) : undefined
|
||||
return {
|
||||
kind: source.kind,
|
||||
conversationId: conversation.id,
|
||||
messageIds: source.messageIds,
|
||||
capturedAt: source.capturedAt,
|
||||
conversationTitle: conversation.title,
|
||||
...(project ? { projectId: project.id, projectName: project.name } : {})
|
||||
}
|
||||
}
|
||||
|
||||
registerHandler(ipcChannels.magicNotesSearch, (event, input: unknown) => {
|
||||
assertTrustedSender(event, window)
|
||||
const { query, limit } = magicNoteSearchSchema.parse(input)
|
||||
return assistantDatabase.searchMagicNoteSummaries(query, limit)
|
||||
})
|
||||
|
||||
registerHandler(ipcChannels.magicNotesList, (event) => {
|
||||
assertTrustedSender(event, window)
|
||||
return { notes: assistantDatabase.listMagicNotes() }
|
||||
@@ -8443,9 +8472,8 @@ export function registerIpcHandlers(
|
||||
|
||||
registerHandler(ipcChannels.magicNotesCreate, (event, input: unknown) => {
|
||||
assertTrustedSender(event, window)
|
||||
return assistantDatabase.createMagicNote(
|
||||
magicNoteCreateSchema.parse(input)
|
||||
)
|
||||
const parsed = magicNoteCreateSchema.parse(input)
|
||||
return assistantDatabase.createMagicNote({ ...parsed, source: resolveMagicNoteSource(parsed.source) })
|
||||
})
|
||||
|
||||
registerHandler(ipcChannels.magicNotesUpdate, (event, input: unknown) => {
|
||||
@@ -8470,6 +8498,7 @@ export function registerIpcHandlers(
|
||||
return assistantDatabase.createMagicNoteEntry({
|
||||
noteId: parsed.noteId,
|
||||
content,
|
||||
source: resolveMagicNoteSource(parsed.source),
|
||||
plainText: magicNotePlainText(content)
|
||||
})
|
||||
}
|
||||
|
||||
@@ -1,5 +1,8 @@
|
||||
// @vitest-environment node
|
||||
import { mkdtemp, rm } from 'node:fs/promises'
|
||||
import fs from 'node:fs'
|
||||
import { randomUUID } from 'node:crypto'
|
||||
import { DatabaseSync } from 'node:sqlite'
|
||||
import { tmpdir } from 'node:os'
|
||||
import { join } from 'node:path'
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
@@ -91,12 +94,104 @@ describe('production preload -> registered IPC -> SQLite canvas persistence', ()
|
||||
open()
|
||||
})
|
||||
afterEach(async () => {
|
||||
vi.restoreAllMocks()
|
||||
await dispose?.()
|
||||
database?.close()
|
||||
bridge.handlers.clear()
|
||||
await rm(directory, { recursive: true, force: true })
|
||||
})
|
||||
|
||||
it('captures verified source labels and preserves them after source deletion, edits and reopen', async () => {
|
||||
const project = database.createProject({ name: 'Actual project', rootPath: directory,
|
||||
description: '', defaultWorkMode: 'execute', runtimeSelection: { provider: 'opencode' } })
|
||||
const header = { id: randomUUID(), title: 'Actual conversation', projectId: project.id, updatedAt: 1 }
|
||||
const messages = Array.from({ length: 120 }, (_, index) => ({ id: randomUUID(),
|
||||
role: index % 2 ? 'assistant' as const : 'user' as const,
|
||||
content: `History ${index}`, state: 'complete' as const, createdAt: index }))
|
||||
database.saveLocalConversations([{ header, messages }])
|
||||
const source = { kind: 'conversation' as const, conversationId: header.id,
|
||||
messageIds: messages.map(message => message.id), capturedAt: '2026-09-26T01:02:03.000Z',
|
||||
conversationTitle: 'Forged title', projectId: randomUUID(), projectName: 'Forged project' }
|
||||
const content = { version: 1 as const, ops: [{ insert: messages.map(message => `${message.role}: ${message.content}\n`).join('') }] }
|
||||
const created = await api.create({ title: 'Captured history', content, source })
|
||||
expect(created.createdEntryId).toBe(created.entries[0]!.id)
|
||||
const expectedSource = { ...source, conversationTitle: header.title, projectId: project.id, projectName: project.name }
|
||||
expect(created.entries[0]!.source).toEqual(expectedSource)
|
||||
expect(created.entries[0]!.content).toEqual(content)
|
||||
const appended = await api.createEntry({ noteId: created.id, content,
|
||||
source: { ...source, kind: 'message', messageIds: [messages[1]!.id] } })
|
||||
expect(appended.entries.find(entry => entry.id === appended.createdEntryId)?.source)
|
||||
.toEqual({ ...expectedSource, kind: 'message', messageIds: [messages[1]!.id] })
|
||||
database.deleteLocalConversation(header.id)
|
||||
const edited = await api.updateEntry({ entryId: created.createdEntryId!, expectedRevision: 0,
|
||||
content: { version: 1, ops: [{ insert: 'Edited copy\n' }] } })
|
||||
expect(edited.entries[0]!.source).toEqual(expectedSource)
|
||||
await reopen()
|
||||
expect(await api.get(created.id)).toEqual(edited)
|
||||
const sql = new DatabaseSync(join(directory, 'assistant.sqlite'))
|
||||
try {
|
||||
const row = sql.prepare('SELECT source_json FROM magic_note_entries WHERE id = ?').get(created.createdEntryId!) as { source_json: string }
|
||||
expect(JSON.parse(row.source_json)).toEqual(expectedSource)
|
||||
} finally { sql.close() }
|
||||
await api.remove(created.id)
|
||||
await expect(api.get(created.id)).rejects.toThrow()
|
||||
})
|
||||
|
||||
it('rejects invalid source identities and source-only creates without leaving empty notes', async () => {
|
||||
const header = { id: randomUUID(), title: 'Global conversation', updatedAt: 1 }
|
||||
const message = { id: randomUUID(), role: 'assistant' as const, content: 'Answer', state: 'error' as const, createdAt: 1 }
|
||||
database.saveLocalConversations([{ header, messages: [message] }])
|
||||
const content = { version: 1 as const, ops: [{ insert: 'Edited preview\n' }] }
|
||||
const source = { kind: 'message' as const, conversationId: header.id, messageIds: [message.id],
|
||||
capturedAt: new Date().toISOString(), conversationTitle: 'Untrusted', projectId: randomUUID(), projectName: 'Untrusted' }
|
||||
await expect(api.create({ title: 'Invalid', source })).rejects.toThrow()
|
||||
await expect(api.create({ title: 'Invalid', content, source: { ...source, messageIds: [randomUUID()] } })).rejects.toThrow()
|
||||
await expect(api.create({ title: 'Invalid', content, source: { ...source, messageIds: [message.id, message.id] } })).rejects.toThrow()
|
||||
await expect(api.create({ title: 'Invalid', content, source: { ...source, conversationId: randomUUID() } })).rejects.toThrow()
|
||||
expect((await api.list()).notes).toEqual([])
|
||||
const note = await api.create({ title: 'Partial answer', content, source })
|
||||
expect(note.entries[0]!.source).toEqual({ kind: 'message', conversationId: header.id,
|
||||
messageIds: [message.id], capturedAt: source.capturedAt, conversationTitle: header.title })
|
||||
await api.remove(note.id)
|
||||
expect(database.getConversation(header.id).messages).toEqual([message])
|
||||
})
|
||||
|
||||
it('rolls back a new note when writing its initial body fails and allows retry', async () => {
|
||||
const rename = fs.renameSync
|
||||
const failure = vi.spyOn(fs, 'renameSync').mockImplementation((from, to) => {
|
||||
if (String(to).includes('entries')) throw new Error('Initial body write failed')
|
||||
rename(from, to)
|
||||
})
|
||||
const input = { title: 'Atomic capture', content: { version: 1 as const, ops: [{ insert: 'Saved once\n' }] } }
|
||||
await expect(api.create(input)).rejects.toThrow('Initial body write failed')
|
||||
expect((await api.list()).notes).toEqual([])
|
||||
failure.mockRestore()
|
||||
const note = await api.create(input)
|
||||
expect(note.entries).toHaveLength(1)
|
||||
expect(note.createdEntryId).toBe(note.entries[0]!.id)
|
||||
expect((await api.list()).notes).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('searches titles and all entry bodies with note-level limits while preserving Agent entry results', async () => {
|
||||
const titleOnly = await api.create({ title: 'Needle title' })
|
||||
expect(titleOnly.createdEntryId).toBeUndefined()
|
||||
const bodyOnly = await api.create({ title: 'Body only', content: { version: 1, ops: [{ insert: 'Needle body\n' }] } })
|
||||
for (let index = 0; index < 4; index++) {
|
||||
await api.createEntry({ noteId: bodyOnly.id, content: { version: 1, ops: [{ insert: `Needle ${index}\n` }] } })
|
||||
}
|
||||
await api.createEntry({ noteId: bodyOnly.id, content: { version: 1, ops: [{ insert: 'Latest unrelated preview\n' }] } })
|
||||
const results = await api.search({ query: ' Needle ', limit: 2 })
|
||||
expect(new Set(results.map(note => note.id))).toEqual(new Set([bodyOnly.id, titleOnly.id]))
|
||||
expect(results.find(note => note.id === bodyOnly.id)).toMatchObject({ entryCount: 6, preview: 'Latest unrelated preview' })
|
||||
expect(database.searchMagicNotes('Needle', 20).filter(result => result.noteId === bodyOnly.id)).toHaveLength(5)
|
||||
await api.update({ noteId: titleOnly.id, pinned: true, expectedRevision: titleOnly.revision })
|
||||
expect((await api.search({ query: 'Needle', limit: 1 })).map(note => note.id)).toEqual([titleOnly.id])
|
||||
expect(await api.search({ query: '%' })).toEqual([])
|
||||
expect(await api.search({ query: '' })).toHaveLength(2)
|
||||
await expect(api.search({ query: 'Needle', limit: 0 })).rejects.toThrow()
|
||||
await expect(api.search({ query: 'Needle', limit: 201 })).rejects.toThrow()
|
||||
})
|
||||
|
||||
it.each([true, false])('limits saved, draft and todo input using persisted page order and count (vision=%s)', async (supportsImageInput) => {
|
||||
getResolvedSettings.mockResolvedValue({ workspacePath: directory, supportsImageInput })
|
||||
const requests: AgentExecutionRequest[] = []
|
||||
|
||||
@@ -53,6 +53,30 @@ function canvas(size = 40): MagicNoteCanvasContent {
|
||||
}
|
||||
|
||||
describe('Magic note SQLite and filesystem storage', () => {
|
||||
it('upgrades schema 47 with nullable sources without rewriting bodies and reopens idempotently', () => {
|
||||
const { database, sql, path, directory } = setup()
|
||||
const created = database.createMagicNote({ title: 'Existing note', content: rich })
|
||||
const before = database.getMagicNote(created.id)
|
||||
const bodyPath = join(directory, 'notes', created.id, 'entries', `${created.createdEntryId}.json`)
|
||||
const body = readFileSync(bodyPath)
|
||||
const modifiedAt = statSync(bodyPath).mtimeMs
|
||||
database.close()
|
||||
// Reconstruct the previous released schema; production never downgrades databases.
|
||||
sql.exec('ALTER TABLE magic_note_entries DROP COLUMN source_json; PRAGMA user_version = 47;')
|
||||
upgradeAssistantStorage(path, () => undefined)
|
||||
expect(sql.prepare('PRAGMA user_version').get()).toEqual({ user_version: ASSISTANT_DATABASE_SCHEMA_VERSION })
|
||||
expect(sql.prepare('SELECT source_json FROM magic_note_entries').get()).toEqual({ source_json: null })
|
||||
expect(sql.prepare('PRAGMA integrity_check').get()).toEqual({ integrity_check: 'ok' })
|
||||
database.initialize(directory)
|
||||
expect(database.getMagicNote(created.id)).toEqual(before)
|
||||
expect(database.getMagicNote(created.id).entries[0]).not.toHaveProperty('source')
|
||||
expect(readFileSync(bodyPath)).toEqual(body)
|
||||
expect(statSync(bodyPath).mtimeMs).toBe(modifiedAt)
|
||||
database.close()
|
||||
database.initialize(directory)
|
||||
expect(database.getMagicNote(created.id)).toEqual(before)
|
||||
})
|
||||
|
||||
it('preserves textual data URLs and arbitrary $asset objects through save, migration and reopen', () => {
|
||||
const { database, sql, path, directory } = setup()
|
||||
const text = 'data:text/plain;base64,aGVsbG8'
|
||||
@@ -61,7 +85,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
const drawing = canvas()
|
||||
drawing.pages[0]!.objects.push({ type: 'IText', ...custom }, { type: 'Group', objects: [{ type: 'Image', src: png, name: text, custom }] })
|
||||
drawing.flow!.ops.push({ insert: text }, { insert: { image: png } }, { insert: { custom } })
|
||||
const notes = [richText, drawing].map((content) => database.createMagicNote({ title: 'Literal URLs', content }))
|
||||
const notes = [richText, drawing].map((content) => database.getMagicNote(database.createMagicNote({ title: 'Literal URLs', content }).id))
|
||||
for (const [index, note] of notes.entries()) expect(note.entries[0]!.content).toEqual([richText, drawing][index])
|
||||
const disk = JSON.parse(readFileSync(join(directory, 'notes', notes[1]!.id, 'entries', `${notes[1]!.entries[0]!.id}.json`), 'utf8'))
|
||||
expect(disk.content.pages[0].objects[2]).toEqual({ type: 'IText', ...custom })
|
||||
@@ -125,7 +149,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
expect(existsSync(root)).toBe(true)
|
||||
expect(logged).toHaveBeenCalled()
|
||||
// A delayed reset cleanup must not remove notes created afterwards.
|
||||
const retained = database.createMagicNote({ title: 'New note', content: canvas() })
|
||||
const retained = database.getMagicNote(database.createMagicNote({ title: 'New note', content: canvas() }).id)
|
||||
failing = false
|
||||
database.listMagicNotes()
|
||||
expect(existsSync(root)).toBe(false)
|
||||
@@ -134,7 +158,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
|
||||
it('still rejects authoritative body rename failures before committing SQL', () => {
|
||||
const { database } = setup()
|
||||
const note = database.createMagicNote({ title: 'Body error', content: rich })
|
||||
const note = database.getMagicNote(database.createMagicNote({ title: 'Body error', content: rich }).id)
|
||||
const entry = note.entries[0]!
|
||||
vi.spyOn(fs, 'renameSync').mockImplementation((source, target) => {
|
||||
if (String(target).endsWith(`${entry.id}.json`)) throw new Error('body rename blocked')
|
||||
@@ -229,6 +253,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
DROP TABLE IF EXISTS supervision_review_navigation; DROP TABLE IF EXISTS supervision_review_batches;
|
||||
DROP TABLE IF EXISTS supervision_review_sources; DROP TABLE IF EXISTS supervision_review_runs;
|
||||
DROP TABLE review_checkpoints; ALTER TABLE messages DROP COLUMN review_revision;
|
||||
ALTER TABLE magic_note_entries DROP COLUMN source_json;
|
||||
PRAGMA user_version = 37`)
|
||||
rmSync(join(directory, 'notes'), { recursive: true })
|
||||
const progress: number[] = []
|
||||
@@ -270,7 +295,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
|
||||
it('reclaims migrated SQLite payload space and restores a coordinated database/files backup', async () => {
|
||||
const { database, sql, directory, path } = setup()
|
||||
const note = database.createMagicNote({ title: 'Large legacy PDF', content: canvas(2 * 1024 * 1024) })
|
||||
const note = database.getMagicNote(database.createMagicNote({ title: 'Large legacy PDF', content: canvas(2 * 1024 * 1024) }).id)
|
||||
const entry = note.entries[0]!
|
||||
database.close()
|
||||
sql.prepare('UPDATE magic_note_entries SET content_json = ? WHERE id = ?').run(JSON.stringify(entry.content), entry.id)
|
||||
@@ -340,7 +365,7 @@ describe('Magic note SQLite and filesystem storage', () => {
|
||||
|
||||
it('rolls back failed creates and cleans their unaccepted files without affecting existing notes', () => {
|
||||
const { database, sql, directory } = setup()
|
||||
const retained = database.createMagicNote({ title: 'Keep', content: rich })
|
||||
const retained = database.getMagicNote(database.createMagicNote({ title: 'Keep', content: rich }).id)
|
||||
sql.exec(`CREATE TRIGGER fail_note_insert BEFORE INSERT ON magic_note_entries
|
||||
BEGIN SELECT RAISE(ABORT, 'insert unavailable'); END`)
|
||||
expect(() => database.createMagicNote({ title: 'Failed', content: canvas() })).toThrow('insert unavailable')
|
||||
|
||||
Reference in New Issue
Block a user