fix: remove redundant confirmation for configuration changes
Configuration apply previously required a separate native confirmation even in Agent Runtime Execute mode, and failed in clients without an approval callback. Use existing work-mode and tool authorization instead, preserving Ask read-only access and request-scoped plan validation. Update regression tests, tool descriptions and documentation. Validation: 267 focused tests passed; typecheck and changed-file lint passed. Full tests timed out with failures in other modules; repository lint reported errors in unchanged files. Release note: Execute 模式下通过 Agent Runtime 修改 GoodBuddy 配置不再额外弹出确认框,Ask 模式仍保持只读。
This commit is contained in:
@@ -68,10 +68,7 @@ import {
|
||||
magicNotePlainText,
|
||||
validateMagicNoteRichContent
|
||||
} from '../magic-notes/rich-content'
|
||||
import type {
|
||||
GoodBuddyConfigApplyAuthorizer,
|
||||
GoodBuddyConfigService
|
||||
} from '../goodbuddy-config-service'
|
||||
import type { GoodBuddyConfigService } from '../goodbuddy-config-service'
|
||||
import {
|
||||
createMcpTransport
|
||||
} from '../capabilities/mcp-client-transport'
|
||||
@@ -214,7 +211,6 @@ type Capability = {
|
||||
magicNotesAccess: MagicNotesCapabilityAccess
|
||||
configAccess: MagicNotesCapabilityAccess
|
||||
configWorkspacePath?: string
|
||||
authorizeConfigApply?: GoodBuddyConfigApplyAuthorizer
|
||||
browserConversationId?: string
|
||||
browserTabId?: BrowserTabId
|
||||
browserUsageLease?: BrowserTabUsageLease
|
||||
@@ -497,7 +493,6 @@ export class KnowledgeMcpGateway {
|
||||
config?: {
|
||||
access: MagicNotesCapabilityAccess
|
||||
workspacePath: string
|
||||
authorizeApply?: GoodBuddyConfigApplyAuthorizer
|
||||
},
|
||||
browserConversationId?: string,
|
||||
browserTabId?: BrowserTabId,
|
||||
@@ -573,8 +568,7 @@ export class KnowledgeMcpGateway {
|
||||
browserUsageLease: effectiveBrowserUsageLease,
|
||||
...(effectiveConfigAccess !== 'none'
|
||||
? {
|
||||
configWorkspacePath: config?.workspacePath,
|
||||
authorizeConfigApply: config?.authorizeApply
|
||||
configWorkspacePath: config?.workspacePath
|
||||
}
|
||||
: {}),
|
||||
signal,
|
||||
@@ -1403,8 +1397,7 @@ export class KnowledgeMcpGateway {
|
||||
result: await service.apply(
|
||||
capability.requestId,
|
||||
input,
|
||||
effectiveSignal,
|
||||
capability.authorizeConfigApply
|
||||
effectiveSignal
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user